Bug 143313 - [PATCH] devel/cmake: fix warning in FindSDL.cmake
Summary: [PATCH] devel/cmake: fix warning in FindSDL.cmake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 15:00 UTC by Dmitry Marakasov
Modified: 2010-01-29 12:14 UTC (History)
1 user (show)

See Also:


Attachments
cmake-2.8.0_3.patch (2.55 KB, patch)
2010-01-28 15:00 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2010-01-28 15:00:19 UTC
My change to FindSDL.cmake introduced a (harmless) warning in apps that use FIND_PACKAGE(SDL):

---
CMake Warning at /usr/local/share/cmake/Modules/FindSDL.cmake:108 (IF):
  given arguments:

    "NOT" "/usr/local/include/SDL" "/usr/local/include" "MATCHES" ".framework"
  
  Unknown arguments specified
Call Stack (most recent call first):
  CMakeLists.txt:3 (FIND_PACKAGE)


---

The patch fixes it. Also fix plist to respect apps that install their own modules into share/cmake/Modules (currently, textproc/soprano and net-im/qutim)

Port maintainer (kde@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer 2010-01-28 15:00:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2010-01-29 11:35:46 UTC
amdmi3      2010-01-29 11:35:33 UTC

  FreeBSD ports repository

  Modified files:
    devel/cmake          Makefile pkg-plist 
    devel/cmake/files    patch-Modules_FindSDL.cmake 
  Log:
  - Fix warning in FindSDL.cmake
  - Use @dirrmtry for Modules dir, as other ports may install their own cmake modules
  
  PR:             143313
  Submitted by:   myself
  Approved by:    Max Brazhnikov <makc@issp.ac.ru>
  
  Revision  Changes    Path
  1.38      +1 -1      ports/devel/cmake/Makefile
  1.2       +20 -2     ports/devel/cmake/files/patch-Modules_FindSDL.cmake
  1.23      +2 -2      ports/devel/cmake/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Dmitry Marakasov freebsd_committer 2010-01-29 12:14:29 UTC
State Changed
From-To: open->closed

Committed. Thanks!