VisualBoyAdvance-M is an emulator of the Game Boy, Super Game Boy, Game Boy Color, and Game Boy Advance. The -M fork is a collection of community patches to the original VisualBoyAdvance. It includes an option GTK frontend. WWW: http://vba-m.com/ Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it.
* okeeblow (root@cooltrainer.org) wrote: It'll need some changes: - You should not package branches/ and dependencies/ while you only need trunk/. - You should use USE_CMAKE and drop explicit dependency on cmake as well as do-configure and do-build targets. See games/spring for example. - You may change SYSCONFDIR by passing it to cmake: CMAKE_ARGS+= -DSYSCONFDIR:STRING="${PREFIX}/etc" if there were no IF( NOT SYSCONFDIR ) check you still could fix it easier like that (no post-patch needed): - SET( SYSCONFDIR "/etc" ) + SET( SYSCONFDIR "${CMAKE_INSTALL_PREFIX}/etc" ) - The software build system supports installation, so you should probably use it, dropping do-install as well. You may need to fix some paths in CMakeLists.txt though. - When GVBAM is not build, you should add -DNO_GTK:BOOL=yes to CMAKE_ARGS, so it's not built even if all depends are present. You can also make SDL frontend optional. - @exec mkdir's in plist are not needed, however you'll need @dirrm's for share/vbam/ui and share/vbam, and @dirrmtry's for share/applications and share/icons with all subdirs. - We require real name here: > X# Whom: okeeblow <root@cooltrainer.org> - As I've understood from CMakeList.txt, assembly is disabled by default, so you should probably add -DUSE_ASM_SCALERS=yes and -DUSE_ASM_CORE=yes to CMAKE_ARGS here. > X.if ${ARCH}=="i386"||${ARCH}=="amd64" > XBUILD_DEPENDS+= nasm:${PORTSDIR}/devel/nasm > X.endif -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
State Changed From-To: open->feedback Ask for submitter fix.
State Changed From-To: feedback->open Feedback received
* Nicole Reid (okeeblow@cooltrainer.org) wrote: > Thanks for the cmake tips. This should be much-improved. The i386 ASM option > is untested, as I only have amd64. Sorry for delay. This looks good except for a couple of simple issues: it installs etc/ file, which is not mentioned in plist: http://people.freebsd.org/~amdmi3/visualboyadvance-m-1.8.0r945.log and will likel require a bit more special processing as described here: http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html Also, it fails to build with custom LOCALBASE http://people.freebsd.org/~amdmi3/visualboyadvance-m-1.8.0r945.localbase.log which should easily be fixed with REINPLACE_ING /usr/local with ${LOCALBASE} in FindSFML.cmake -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
amdmi3 2010-09-15 22:37:41 UTC FreeBSD ports repository Modified files: emulators Makefile Added files: emulators/visualboyadvance-m Makefile distinfo pkg-descr pkg-plist emulators/visualboyadvance-m/files patch-src-common-Patch.cpp patch-src-gtk-gvbam.desktop Log: VisualBoyAdvance-M is an emulator of the Game Boy, Super Game Boy, Game Boy Color, and Game Boy Advance. The -M fork is a collection of community patches to the original VisualBoyAdvance. It includes an option GTK frontend. WWW: http://vba-m.com/ PR: 144064 Submitted by: okeeblow <root@cooltrainer.org> Revision Changes Path 1.291 +1 -0 ports/emulators/Makefile 1.1 +67 -0 ports/emulators/visualboyadvance-m/Makefile (new) 1.1 +3 -0 ports/emulators/visualboyadvance-m/distinfo (new) 1.1 +11 -0 ports/emulators/visualboyadvance-m/files/patch-src-common-Patch.cpp (new) 1.1 +7 -0 ports/emulators/visualboyadvance-m/files/patch-src-gtk-gvbam.desktop (new) 1.1 +6 -0 ports/emulators/visualboyadvance-m/pkg-descr (new) 1.1 +30 -0 ports/emulators/visualboyadvance-m/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed New port added, with minor changes. Thanks!
amdmi3 2010-09-24 18:19:26 UTC FreeBSD ports repository Modified files: emulators/visualboyadvance-m Makefile pkg-descr pkg-plist Added files: emulators/visualboyadvance-m/files patch-CMakeLists.txt Log: - Add missing bits of the previous commit that somehow were not committed, this also fixed build - Bump PORTREVISION PR: 144064 Submitted by: okeeblow <root@cooltrainer.org> Revision Changes Path 1.2 +7 -0 ports/emulators/visualboyadvance-m/Makefile 1.1 +12 -0 ports/emulators/visualboyadvance-m/files/patch-CMakeLists.txt (new) 1.2 +1 -1 ports/emulators/visualboyadvance-m/pkg-descr 1.2 +3 -0 ports/emulators/visualboyadvance-m/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"