Bug 146807 - Incorrect LIB_DEPENDS in print/hplip
Summary: Incorrect LIB_DEPENDS in print/hplip
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-21 22:30 UTC by Peter Jeremy
Modified: 2010-05-22 07:40 UTC (History)
1 user (show)

See Also:


Attachments
patch-cups-hplip.txt (1.29 KB, patch)
2010-05-21 19:39 UTC, Chris Petrik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Petrik 2010-05-21 19:39:06 UTC
Hello,

Please find attached patch, which should fix the issue you have.
Comment 1 Peter Jeremy 2010-05-21 22:30:01 UTC
	print/hplip has "cups.2:${PORTSDIR}/print/cups-base" in LIB_DEPENDS
	but libsane.so.2 is actually installed by print/cups-client.  If
	cups-client is already installed but some other parts of cups-base
	are not installed the the build of print/hplip will fail.

	I ran into this because one of the cups-base dependencies failed
	but when I corrected that problem and restarted the hplip build,
	it then skipped installing the rest of cups-base.

                  already been installed before the cups build exploded.
	
[07:02:13 @peter] I have just bumped into a ports glitch.  I was building
                  print/hplip, which had grown the dependency tree hplip ->
                  cups-base -> ghostscript8 -> png which exploded because I
                  still had the old png installed.  I upgraded png and
                  restarted.  This time, hplip thought all the dependencies were
                  in place and started to build.  It got partway through and
                  exploded because some cups headers were missing.
[07:04:07 @peter] The problem is that hplip has

Fix: 

hplip should include a BUILD_DEPENDS on something that is
	directly installed by cups-base.
How-To-Repeat: 	Remove all CUPS-related ports.
	cd /usr/ports/print/cups-client && make install
	cd /usr/ports/print/hplip && make
	This fails with:
...
pe -march=pentium3 -fno-strict-aliasing -c -o hpcups-HPCupsFilter.o `test -f 'prnt/hpcups/HPCupsFilter.cpp' || echo './'`prnt/hpcups/HPCupsFilter.cpp
In file included from prnt/hpcups/HPCupsFilter.h:34,
                 from prnt/hpcups/HPCupsFilter.cpp:31:
prnt/hpcups/CommonDefinitions.h:41:25: error: cups/raster.h: No such file or directory
In file included from prnt/hpcups/HPCupsFilter.cpp:31:
prnt/hpcups/HPCupsFilter.h:100: error: 'cups_page_header2_t' has not been declared
prnt/hpcups/HPCupsFilter.h:101: error: 'cups_raster_t' has not been declared
prnt/hpcups/HPCupsFilter.h:102: error: 'cups_page_header2_t' has not been declared
prnt/hpcups/HPCupsFilter.h:104: error: 'cups_page_header2_t' has not been declared
prnt/hpcups/HPCupsFilter.cpp:233: error: 'DRIVER_ERROR HPCupsFilter::startPage' is not a static member of 'class HPCupsFilter'
prnt/hpcups/HPCupsFilter.cpp:233: error: 'cups_page_header2_t' was not declared in this scope
prnt/hpcups/HPCupsFilter.cpp:233: error: 'cups_header' was not declared in this scope
prnt/hpcups/HPCupsFilter.cpp:234: error: expected ',' or ';' before '{' token
*** Error code 1
1 error
*** Error code 1

Stop in /usr/ports/print/hplip.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-21 22:30:11 UTC
Maintainer of print/hplip,

Please note that PR ports/146807 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146807

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-21 22:30:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 dfilter service freebsd_committer freebsd_triage 2010-05-22 07:33:38 UTC
miwi        2010-05-22 06:33:24 UTC

  FreeBSD ports repository

  Modified files:
    print/hplip          Makefile 
  Log:
  - Add missing dependency
  
  PR:             146807
  Reported by:    Peter Jeremy <peterjeremy@acm.org>
  Patched by:     maintainer
  
  Revision  Changes    Path
  1.33      +9 -2      ports/print/hplip/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2010-05-22 07:34:00 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!