When trying to make package of ports/databases/skytools, I get: Creating bzip'd tar ball in '/usr/packages/All/skytools-2.1.11.tbz' tar: lib/postgresql/txid.so: Cannot stat: No such file or directory tar: share/doc/postgresql/contrib/README.txid: Cannot stat: No such file or directory tar: share/postgresql/contrib/uninstall_txid.sql: Cannot stat: No such file or directory tar: share/postgresql/contrib/txid.sql: Cannot stat: No such file or directory tar: share/skytools/txid.sql: Cannot stat: No such file or directory tar: Error exit delayed from previous errors. pkg_create: make_dist: tar command failed with code 256 *** Error code 1 Stop in /usr/ports/databases/skytools. I think it is because of skytools-2.1.11/sql/txid/Makefile checks the version of PostgreSQL and don't compile txid for PGVER > 8.2, but skytools's pkg-plist have unconditional lines for txid. How-To-Repeat: cd /usr/ports/databases/postgresql84-server make package clean cd /usr/ports/databases/skytools make package clean
Maintainer of databases/skytools, Please note that PR ports/146913 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146913 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Yes, TXID has been incorporated into core pg since Oct 2007, http://git.postgresql.org/gitweb?p=postgresql.git;a=commit;h=3c889210f443fece4aa28edf7dafecd4ddbc2e77 . As such, all references to them are no longer required and can be safely removed from pkg-plist. Attached is a patch that removes the affacted files. Regards, Khee Chin. On Mon, May 24, 2010 at 3:50 PM, Edwin Groothuis <edwin@freebsd.org> wrote: > Maintainer of databases/skytools, > > Please note that PR ports/146913 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > Â Â http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146913 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org >
Hi, your patch inverts the problem for installations with PostgreSQL 8.2, which is the default version; on those systems, the files are installed by skytools, but don't appear in the plist any more and so would not be deinstalled. Either the plist should be changed dynamically, depending on which PostgreSQL version is installed, or you should set USE_PGSQL/WANT_PGSQL_VER to the version you want. Regards, Stefan
Responsible Changed From-To: freebsd-ports-bugs->stefan Track this/waiting for maintainer feedback.
Responsible Changed From-To: stefan->freebsd-ports-bugs Return this PR to the pool - I currently do not have the time to take care of it.
State Changed From-To: feedback->open submitter feedback timeout: (Alexey Markov <redrat@mail.ru> ; 45 days)
State Changed From-To: open->closed Fixed, thanks for report
pav 2010-12-02 14:55:37 UTC FreeBSD ports repository Modified files: databases/skytools Makefile pkg-plist Log: - txid bits are installed conditionally on postgresql version, fix plist PR: ports/146913 Reported by: Alexey Markov <redrat@mail.ru> Approved by: feedback timeout on the PR Revision Changes Path 1.10 +20 -1 ports/databases/skytools/Makefile 1.5 +5 -5 ports/databases/skytools/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"