Bug 146961 - [patch] devel/git: strip(1) binaries by default for non-debug builds
Summary: [patch] devel/git: strip(1) binaries by default for non-debug builds
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 11:00 UTC by swell.k
Modified: 2010-11-19 07:10 UTC (History)
0 users

See Also:

Attachments
a.diff (519 bytes, patch)
2010-05-25 11:00 UTC, swell.k 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2010-05-25 11:00:05 UTC 

Fix: Mimic bsd.port.mk behavior. This should depend on whether ${STRIP} has
`-s', though. Even better would be to strip binaries by install(1),
e.g. by using BSD_INSTALL_PROGRAM.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-05-25 11:00:28 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Wesley Shields freebsd_committer freebsd_triage 2010-07-04 19:51:25 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 swell.k 2010-11-19 07:02:48 UTC 
Hmm, it's better to use same check as in ports/150689.

WITH_DEBUG is for things like -DDEBUG, i.e. compile-time optimization
that hurts performance while debug symbols usually do not.

--- a.diff begins here ---
Index: devel/git/Makefile
===================================================================
RCS file: /a/.cvsup/ports/devel/git/Makefile,v
retrieving revision 1.94
diff -u -p -r1.94 Makefile
--- devel/git/Makefile	23 Oct 2010 15:07:55 -0000	1.94
+++ devel/git/Makefile	26 Oct 2010 19:32:27 -0000
@@ -195,7 +195,7 @@ OPTIONS=	GUI "Enable building of GUI too
 
 .include <bsd.port.options.mk>
 
-.ifndef (WITH_DEBUG)
+.ifdef (STRIP) && ${STRIP} != ""
 ALL_TARGET=	all strip
 .endif
 
--- a.diff ends here ---