Bug 148101 - x11/startup-notification Makefile missing library dependencies [patch]
Summary: x11/startup-notification Makefile missing library dependencies [patch]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-24 07:30 UTC by Don Lewis
Modified: 2010-07-14 16:30 UTC (History)
0 users

See Also:

Attachments
file.diff (892 bytes, patch)
2010-06-24 07:30 UTC, Don Lewis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Lewis freebsd_committer freebsd_triage 2010-06-24 07:30:05 UTC 
	The Makefile for the x11/startup-notification port does not
	list all of the library dependencies used by the port.

	When reinstalling all of the previously installed ports after a
	major FreeBSD release upgrade using "portupgrade -N", portupgrade
	might attempt to build x11/startup-notification before all of its
	dependencies have been installed, which will cause the build to
	fail.

	libtool: link: cc -O2 -pipe -fno-strict-aliasing -Wall -o .libs/test-watch-xmessages-xcb test-watch-xmessages-xcb.o  -L/usr/local/lib ../libsn/.libs/libstartup-notification-1.so /usr/local/lib/libxcb-aux.so /usr/local/lib/libxcb-event.so /usr/local/lib/libxcb-atom.so /usr/local/lib/libSM.so /usr/local/lib/libICE.so /usr/local/lib/libX11.so /usr/local/lib/libxcb.so /usr/local/lib/libXau.so /usr/local/lib/libXdmcp.so /usr/local/lib/libpthread-stubs.so -lrpcsvc -Wl,-rpath -Wl,/usr/local/lib

How-To-Repeat: 	Remove the containing one of the libraries that startup-notification
	links against (such as x11/libSM) and attempt to build
	startup-notification.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-24 07:30:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jeremy Messenger freebsd_committer freebsd_triage 2010-06-24 21:11:13 UTC 
State Changed
From-To: open->closed

If portupgrade inable to understand what need to do then it's a portupgrade 
bug. The portmaster will do it in order correct by check lower dependencies 
first before update main port. This port already has all dependencies listed 
by view in 'make all-depends-list' and no pointyhat failure.
Comment 3 Jeremy Messenger freebsd_committer freebsd_triage 2010-07-14 16:24:31 UTC 
State Changed
From-To: closed->open

open...
Comment 4 Jeremy Messenger freebsd_committer freebsd_triage 2010-07-14 16:24:50 UTC 
State Changed
From-To: open->closed

Just wanted to open and re-closed it for it can have better comment history. 

Anyway, I think I must have looked at the wrong configure last time. I have 
checked in the configure again today and indeed it has ICE/SM in there. I 
have committed by add ICE/SM dependency. Thanks! and sorry.
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-07-14 16:25:28 UTC 
mezz        2010-07-14 15:24:13 UTC

  FreeBSD ports repository

  Modified files:
    x11/startup-notification Makefile 
  Log:
  Add libSM and libICE in the dependency as those will be linked when those
  exist in the system. Bump the PORTREVISION.
  
  PR:             ports/148101
  Submitted by:   truckman
  Feature safe:   yes
  
  Revision  Changes    Path
  1.29      +3 -1      ports/x11/startup-notification/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"