Bug 152331 - [PATCH] dns/nsd improve rc script
Summary: [PATCH] dns/nsd improve rc script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-17 14:20 UTC by phil
Modified: 2010-11-24 15:50 UTC (History)
0 users

See Also:


Attachments
nsd-in.patch (1.16 KB, patch)
2010-11-17 14:20 UTC, phil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description phil 2010-11-17 14:20:09 UTC
	I propose this improvement for nsd rc script.

	- Add status and reload commands
	- nsd refuse to start without database, launch nsdc rebuild if database doesn't exists
	- Remove sleep from stop command (I suppose nsdc patch block until finished no ?)
Comment 1 Edwin Groothuis freebsd_committer 2010-11-17 14:20:17 UTC
Maintainer of dns/nsd,

Please note that PR ports/152331 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/152331

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2010-11-17 14:20:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Jaap Akkerhuis 2010-11-24 13:21:17 UTC
Yes, this seems fine to me.

Thanks Philippe.

	jaap

    Maintainer of dns/nsd,
    
    Please note that PR ports/152331 has just been submitted.
    
    If it contains a patch for an upgrade, an enhancement or a bug fix
    you agree on, reply to this email stating that you approve the patch
    and a committer will take care of it.
    
    The full text of the PR can be found at:
        http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/152331
    
    -- 
    Edwin Groothuis via the GNATS Auto Assign Tool
    edwin@FreeBSD.org
Comment 4 Baptiste Daroussin freebsd_committer 2010-11-24 13:23:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bapt

I'll take it.
Comment 5 dfilter service freebsd_committer 2010-11-24 15:44:22 UTC
bapt        2010-11-24 15:44:15 UTC

  FreeBSD ports repository

  Modified files:
    dns/nsd              Makefile 
    dns/nsd/files        nsd.in 
  Log:
  improvements on rc script:
   - support reload command
   - use nsdc cli has command and let it perform the actual start,stop,... of the daemon
   - at start check if the database exists if not built it (this prevent the daemon to fail at starting)
   - remove the now userless sleep in stop command
  
  bump portrevision
  
  PR:             ports/152331
  Submitted by:   Philippe Pepiot <phil _at_ philpep.org>
  Approved by:    Jaap Akkerhuis <jaap _at_ NLnetLabs.nl> (maintainer)
  
  Revision  Changes    Path
  1.50      +1 -0      ports/dns/nsd/Makefile
  1.7       +22 -7     ports/dns/nsd/files/nsd.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Baptiste Daroussin freebsd_committer 2010-11-24 15:44:30 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!