Bug 152524 - sysutils/hal: hald runs busy after devd stopped.
Summary: sysutils/hal: hald runs busy after devd stopped.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-23 09:20 UTC by KOIE Hidetaka
Modified: 2011-01-08 18:10 UTC (History)
0 users

See Also:


Attachments
file.diff (637 bytes, patch)
2010-11-23 09:20 UTC, KOIE Hidetaka
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KOIE Hidetaka 2010-11-23 09:20:11 UTC
Usually devd does not stop, but
hald comsumes CPU 100% after /etc/rc.d/devd stop or restart.

Fix: In /usr/ports/sysutils/hal/work/hal-0.5.14/hald/freebsd/hf-devd.c,
becasue hf_devd_event_cb() does not handle G_IO_STATUS_EOF event,
the event loop runs forever.
this patch stops the event storm.
hald should re-connect to devd if devd restarts.

Patch attached with submission follows:
How-To-Repeat: /etc/rc.d/devd restart
Comment 1 Koop Mast freebsd_committer 2010-11-23 11:07:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Assign to maintainer
Comment 2 Joe Marcus Clarke freebsd_committer 2011-01-08 18:05:50 UTC
State Changed
From-To: open->closed

I fixed this using the existing restart code.  Thanks for reporting.
Comment 3 dfilter service freebsd_committer 2011-01-08 18:05:53 UTC
marcus      2011-01-08 18:05:48 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/hal         Makefile 
  Added files:
    sysutils/hal/files   patch-hald_freebsd_hf-devd.c 
  Log:
  Check for G_IO_STATUS_EOF when reading from the devd socket to prevent
  an event storm.
  
  PR:             152524
  
  Revision  Changes    Path
  1.67      +1 -1      ports/sysutils/hal/Makefile
  1.4       +11 -0     ports/sysutils/hal/files/patch-hald_freebsd_hf-devd.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"