Bug 154985 - PATCH - Upgrade databases/p5-DBIx-SearchBuilder to 1.59
Summary: PATCH - Upgrade databases/p5-DBIx-SearchBuilder to 1.59
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Sivachenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-23 20:10 UTC by mikeg
Modified: 2011-02-28 15:06 UTC (History)
0 users

See Also:

Attachments
file.diff (835 bytes, patch)
2011-02-23 20:10 UTC, mikeg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mikeg 2011-02-23 20:10:09 UTC 
The attached patch updates the databases/p5-DBIx-SearchBuilder port to the latest version (1.59) -- this is a requirement for the upcoming RT 4.0 release.

Note that there is one INCOMPATIBLE CHANGE noted in the changelog:

* INCOMPATIBLE CHANGE: NextPage and PrevPage were adding rows from
  the previous page. Jesse claims that when he wrote this code, he
  was 20 years old and it seemed like a good idea at the time.

My understanding is that this change makes the code behave as a sane person would expect, however there may be unanticipated consequences to code that depends on the old behavior -- I'd be OK with spinning off a 1.59 port with me as maintainer if necessary.

Fix: Patch attached

Patch attached with submission follows:
How-To-Repeat: Try to install RT 4.0 (or any other code that requires DBIx-SearchBuilder > 1.56)
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-02-25 02:14:06 UTC 
Responsible Changed
From-To: freebsd-bugs->demon

Make this a ports PR, fix the spelling of the port, and assign.
Comment 2 Dmitry Sivachenko freebsd_committer freebsd_triage 2011-02-28 15:05:55 UTC 
State Changed
From-To: open->closed

Port updated, thanks!