In file panel-plugin/memswap.c , the author defined the *_pages variables as int, which is long enough to represent the length of pages. But he multiplied the total_pages by pagesize, so the overflow occurred. Fix: Use the authors' own macro CONVERT(_pages), which casts the page length into quad_t, to calculate the memory sizes. Patch attached with submission follows: How-To-Repeat: Starts xfce4-systemload-plugin on a system with more than 3.5GB real memory, you will see a very huge number for the total memory (If the used memory is larger than 3.5GB, no lucky).
Responsible Changed From-To: freebsd-ports-bugs->pgollucci pgollucci@ wants this port PRs (via the GNATS Auto Assign Tool)
Maintainer of sysutils/xfce4-systemload-plugin, Please note that PR ports/155382 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155382 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Maintainer timeout. Please just commit the patch included.
Responsible Changed From-To: pgollucci->freebsd-ports-bugs E-NO-TIME right now, back to pool
Responsible Changed From-To: freebsd-ports-bugs->makc I'll take it.
State Changed From-To: feedback->open Maintainer timeout
State Changed From-To: open->closed Committed. Thanks!
makc 2011-07-03 12:04:37 UTC FreeBSD ports repository Modified files: sysutils/xfce4-systemload-plugin Makefile Added files: sysutils/xfce4-systemload-plugin/files patch-panel-plugin__memswap.c patch-panel-plugin__uptime.c Log: Fix reported memory size on systems with more than 3.5GB real memory. PR: ports/155382 Submitted by: Zhihao Yuan <lichray at gmail.com> Approved by: maintainer timeout (several months) Revision Changes Path 1.37 +1 -1 ports/sysutils/xfce4-systemload-plugin/Makefile 1.1 +13 -0 ports/sysutils/xfce4-systemload-plugin/files/patch-panel-plugin__memswap.c (new) 1.1 +11 -0 ports/sysutils/xfce4-systemload-plugin/files/patch-panel-plugin__uptime.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"