Bug 155441 - [loader] [patch] Firewire support in loader is broken
Summary: [loader] [patch] Firewire support in loader is broken
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 8.1-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 16:10 UTC by longwitz
Modified: 2019-01-08 20:03 UTC (History)
1 user (show)

See Also:
imp: mfc-stable11+
imp: mfc-stable12+


Attachments
file.diff (1.59 KB, patch)
2011-03-10 16:10 UTC, longwitz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description longwitz 2011-03-10 16:10:11 UTC
With LOADER_FIREWIRE_SUPPORT=yes the loader includes firewire support.

In /usr/src/sys/boot/i386/libfirewire/firewire.c the call of the function
biospci_write_config is not correct (the second and third parameter must
be swapped). Some hardware complains about this, some do not.

Also only the first firewire device is supported - in my opinion
unnecessarily.

Fix: Patch attached with submission follows:
How-To-Repeat: Try to use the loader over firewire.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-03-21 03:21:12 UTC
Responsible Changed
From-To: freebsd-i386->freebsd-bugs

reclassify.
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:37 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 3 commit-hook freebsd_committer 2019-01-08 20:02:09 UTC
A commit references this bug:

Author: imp
Date: Tue Jan  8 20:01:57 UTC 2019
New revision: 342865
URL: https://svnweb.freebsd.org/changeset/base/342865

Log:
  biospci_write_config args were backwards

  biospci_write_config args swapped length and value to write. Some
  hardware coped just fine, while other hardware had issues.

  PR: 155441
  Submitted by: longwitz at incore dot de

Changes:
  head/stand/i386/libfirewire/firewire.c
Comment 4 Warner Losh freebsd_committer 2019-01-08 20:03:20 UTC
Ooops... need to leave open for MFC