Bug 155745 - [patch] sysutils/xfce4-battery-plugin 1.0.0 always shows 0% for ACPI battery
Summary: [patch] sysutils/xfce4-battery-plugin 1.0.0 always shows 0% for ACPI battery
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-21 10:50 UTC by John Marshall
Modified: 2012-04-17 22:50 UTC (History)
0 users

See Also:

Attachments
xfce4-battery-plugin.diff (2.85 KB, patch)
2011-03-21 10:50 UTC, John Marshall 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Marshall 2011-03-21 10:50:01 UTC 
There is an outstanding bug in the plugin source which results in ACPI
batteries on FreeBSD always showing 0%.  The previous version of the
port included a patch to address this, but that was sent to the attic
with the 1.0.0 update.  Some years ago, two patches were submitted to
the Xfce folks but insufficient testers were available to convince the
developers to commit.

 <http://bugzilla.xfce.org/show_bug.cgi?id=2814>

I took what looks to be the preferred patch (submitted by Shigeru
Fujiwara on 2007-01-28) and realigned it to suit the current version of
the source file.  It "works for me" on FreeBSD/i386 8.2 and Xfce 4.8.0.

Fix: - Modify Makefile: Bump PORTREVISION
 - Add files/patch-panel-plugin_libacpi.c
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-21 10:50:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2011-03-27 11:36:21 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-03-27 11:36:25 UTC 
miwi        2011-03-27 10:36:11 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/xfce4-battery-plugin Makefile 
  Added files:
    sysutils/xfce4-battery-plugin/files 
                                        patch-panel-plugin_libacpi.c 
  Log:
  - Fix Battery Status
  
  PR:             155745
  Submitted by:   John Marshall <john.marshall@riverwillow.com.au>
  
  Revision  Changes    Path
  1.42      +1 -0      ports/sysutils/xfce4-battery-plugin/Makefile
  1.1       +82 -0     ports/sysutils/xfce4-battery-plugin/files/patch-panel-plugin_libacpi.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Rodrigo OSORIO 2012-04-17 22:33:27 UTC 
Hi,

I want to inform you that the xfce project just merge the
freebsd patch submited in this PR into their HEAD.

See the link below :
http://git.xfce.org/panel-plugins/xfce4-battery-plugin/commit/?id=5fdc701440f97cee111a2a47c85f7d838aab7e13

Future versions of xfce probably doesn't require this patch anymore.

Regards,

- Rodrigo
Comment 5 Olivier Duchateau 2012-04-17 22:40:21 UTC 
I'm following recent updates (to prepare Xfce 4.10), and I saw this commit.

2012/4/17 Rodrigo OSORIO <rodrigo@bebik.net>:
> Hi,
>
> I want to inform you that the xfce project just merge the
> freebsd patch submited in this PR into their HEAD.
>
> See the link below :
> http://git.xfce.org/panel-plugins/xfce4-battery-plugin/commit/?id=5fdc701440f97cee111a2a47c85f7d838aab7e13
>
> Future versions of xfce probably doesn't require this patch anymore.
>
> Regards,
>
> - Rodrigo
>
>
> _______________________________________________
> freebsd-xfce@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-xfce
> To unsubscribe, send any mail to "freebsd-xfce-unsubscribe@freebsd.org"



-- 
olivier