Bug 155789 - sysutils/busybox: don't strip the binary when WITH_DEBUG is set
Summary: sysutils/busybox: don't strip the binary when WITH_DEBUG is set
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-22 17:40 UTC by Vitaly Magerya
Modified: 2011-03-23 15:20 UTC (History)
0 users

See Also:


Attachments
file.diff (285 bytes, patch)
2011-03-22 17:40 UTC, Vitaly Magerya
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Magerya 2011-03-22 17:40:01 UTC
Busybox build system strips the binary by default, so even if you 
build the port with WITH_DEBUG defined the resulting binary is still
stripped.

The attached patch disables the stripping that the build system
performs, and allows our port system to strip the binary when
necessary. This way WITH_DEBUG actually works.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2011-03-22 17:40:21 UTC
Maintainer of sysutils/busybox,

Please note that PR ports/155789 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155789

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2011-03-22 17:40:23 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Sunpoet Po-Chuan Hsieh freebsd_committer 2011-03-22 17:52:36 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I will take it.
Comment 4 Chris Rees 2011-03-22 18:04:04 UTC
Looks great, thanks!

Chris
Comment 5 dfilter service freebsd_committer 2011-03-23 15:11:48 UTC
sunpoet     2011-03-23 15:11:33 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/busybox     Makefile 
  Log:
  - Respect WITH_DEBUG: do not strip the binary by default
  - Use bsd.port.mk
  
  PR:             ports/155789
  Submitted by:   Vitaly Magerya <vmagerya@gmail.com>
  Approved by:    Chris Rees <utisoft@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.13      +2 -3      ports/sysutils/busybox/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Sunpoet Po-Chuan Hsieh freebsd_committer 2011-03-23 15:12:20 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!