Bug 157289 - repquota(8) does not mark overquota users with a "+" sign
Summary: repquota(8) does not mark overquota users with a "+" sign
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 8.1-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-24 10:00 UTC by Victor Sudakov
Modified: 2017-12-31 22:32 UTC (History)
0 users

See Also:


Attachments
smime.p7s (5.05 KB, application/pkcs7-signature)
2011-06-05 20:48 UTC, Dmitry Banschikov
no flags Details
smime.p7s (5.05 KB, application/pkcs7-signature)
2011-06-06 07:45 UTC, Dmitry Banschikov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2011-05-24 10:00:21 UTC
/usr/sbin/repquota should show a "+" sign if a user is overquota. This
worked in 4.x. Now repquota always shows "--" no matter if the user is
over quota or not.

Fix: 

None that I know of.
How-To-Repeat: Run repquota, find a user exceeding her disk quota, make sure that
repquota reports "--" instead of "-+" or "+-".
Comment 1 Dmitry Banschikov 2011-06-05 20:48:17 UTC
This is a multi-part message in MIME format.
Comment 2 Victor Sudakov 2011-06-06 02:49:20 UTC
Dmitry Banschikov wrote:
> Hello.
> 
> I can not reproduce this bug on my system (uname -a output is included - 
> [1]). Output from repquota command is attached. Can you provide more 
> information about your installation (/etc/fstab and repquota output).

Here you are:

#
#
# quota sudakov
Disk quotas for user sudakov (uid 3001):
     Filesystem   usage   quota   limit   grace   files   quota   limit   grace
          /home 4527564*      0 4096000    none   19000       0       0
# repquota /home | grep sudakov
sudakov          --  4527564        0  4096000      -    19000       0       0
    -
# grep /home /etc/fstab
/dev/da1s1h     /home   ufs rw,acls,userquota   2 2
/home/ntd               /var/ftp/ntd            nullfs  ro              0 0
#

-- 
Victor Sudakov,  VAS4-RIPE, VAS47-RIPN
sip:sudakov@sibptus.tomsk.ru
Comment 3 Victor Sudakov 2011-06-06 05:16:49 UTC
Dmitry Banschikov wrote:
> 
> I can not reproduce this bug on my system (uname -a output is included - 
> [1]). Output from repquota command is attached. Can you provide more 
> information about your installation (/etc/fstab and repquota output).

Looks like the "+" sign is present only if a soft limit is configured
for the user. Is this by design?


-- 
Victor Sudakov,  VAS4-RIPE, VAS47-RIPN
sip:sudakov@sibptus.tomsk.ru
Comment 4 Dmitry Banschikov 2011-06-06 07:45:48 UTC
On 06.06.2011 08:16, Victor Sudakov wrote:
> Dmitry Banschikov wrote:
>>
>> I can not reproduce this bug on my system (uname -a output is included -
>> [1]). Output from repquota command is attached. Can you provide more
>> information about your installation (/etc/fstab and repquota output).
>
> Looks like the "+" sign is present only if a soft limit is configured
> for the user. Is this by design?
>
>


This behavior is inherited from the first version of the repquota command.
Here is the code (similar for inodes number):

     fup->fu_dqblk.dqb_bsoftlimit &&
      fup->fu_dqblk.dqb_curblocks >=
      fup->fu_dqblk.dqb_bsoftlimit ? '+' : '-'

So, you are right, sign "+" is present only if user has configured soft 
limit.



-- 

Dmitry Banschikov
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:30 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped