Bug 157803 - [PATCH] update net-im/imspector and take mainteinership
Summary: [PATCH] update net-im/imspector and take mainteinership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-12 23:20 UTC by m.tsatsenko
Modified: 2011-06-13 20:32 UTC (History)
0 users

See Also:

Attachments
file.diff (9.37 KB, patch)
2011-06-12 23:20 UTC, m.tsatsenko 		no flags Details | Diff
imspector.diff (8.14 KB, patch)
2011-06-13 13:44 UTC, m.tsatsenko 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description m.tsatsenko 2011-06-12 23:20:09 UTC 
- Update port to 0.9
- Add LICENCE
- Claim mainteinership
- Update COMMENT to fit in 70 chars (in order to make portlint happy)
Comment 1 Julien Laffaye freebsd_committer freebsd_triage 2011-06-12 23:54:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jlaffaye

I'll take it.
Comment 2 Julien Laffaye freebsd_committer freebsd_triage 2011-06-13 12:35:56 UTC 
State Changed
From-To: open->feedback

You removed support for configuration files. Please see the handbook [1] and resubmit the updated diff as a followup to this PR. 
Also, this port links to openssl so it should have USE_OPENSSL=yes. 
Last but not least, you made a wrong usage of PREFIX in CFLAGS: it should be LOCALBASE. 

[1]: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-config.html
Comment 3 m.tsatsenko 2011-06-13 13:44:53 UTC 
Corrected pacth attached
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-06-13 20:28:53 UTC 
jlaffaye    2011-06-13 19:28:35 UTC

  FreeBSD ports repository

  Modified files:
    net-im/imspector     Makefile distinfo pkg-plist 
    net-im/imspector/files patch-Makefile patch-imspector.conf 
  Added files:
    net-im/imspector/files patch-icqprotocolplugin.cpp 
  Log:
  Update to 0.9
  Add LICENSE
  Submitter is now maintainer
  
  PR:             ports/157803
  Submitted by:   "Mikhail T." <m.tsatsenko@gmail.com>
  Approved by:    bapt (mentor)
  
  Revision  Changes    Path
  1.5       +8 -4      ports/net-im/imspector/Makefile
  1.3       +2 -2      ports/net-im/imspector/distinfo
  1.2       +26 -15    ports/net-im/imspector/files/patch-Makefile
  1.1       +11 -0     ports/net-im/imspector/files/patch-icqprotocolplugin.cpp (new)
  1.2       +38 -7     ports/net-im/imspector/files/patch-imspector.conf
  1.2       +9 -0      ports/net-im/imspector/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Julien Laffaye freebsd_committer freebsd_triage 2011-06-13 20:32:11 UTC 
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!