Bug 158086 - [digi] [patch] Update digi(4) to work with TTYng
Summary: [digi] [patch] Update digi(4) to work with TTYng
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 9.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 05:50 UTC by Peter.Jeremy
Modified: 2018-05-20 18:44 UTC (History)
0 users

See Also:


Attachments
file.diff (68.11 KB, patch)
2011-06-21 05:50 UTC, Peter.Jeremy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter.Jeremy 2011-06-21 05:50:08 UTC
	The digi(4) driver needs updating to work with TTYng.  The patch
	below does this.  The code has also been cross-checked against
	the Linux driver (dgap-1.3) available from Digi.

	Notes:
	- kern/152254 must be committed before this PR
	- Only PCI DigiBoards are supported.  Additional locking would
	  be required to support ISA cards and I do not have access to
	  any for testing.
	- The code still handles firmware loading/unloading itself
	  rather than using firmware(9) because each card needs two
	  or three firmware images and the current approach allows
	  one kld per card, rather than one kld per image.
	- Interrupt or polling mode can be selected at compile time.
	- Giant is no longer used.
	- The softc has been rototilled to reduce the amount of padding
	- If compiled with debugging, a sysctl is available to control
	  verbosity.
	- This patch still includes debugging code.

How-To-Repeat: 	Try to compile digi(4) on 8.0 or later.
Comment 1 David Boyd 2011-07-09 20:33:53 UTC
Per communications with Peter Jeremy and Gavin Atkinson:

Applied patches kern/152254 and kern/158086 to 8.2-RELEASE(-p2) and
9.0-CURRENT.

Testing of Digi Acceleport Xr (8-port) PCI went as follows:

	Modem (dial-out) no issues.

	Modem (dial-in) still waiting for digi hardware at remote end. (This may
not happen).

	Serial console:

		8.2-RELEASE(-p2) no issues.

		9.0-CURRENT strange behavior with extended keypad keys PAGE-UP, PAGE-DOWN,
INSERT
			and DELETE echos "~" character to display and exits dialog application.

			This behavior was reproducible on COM1 (uart) port,
			on SIIG (puc) ports and on USB (uplcom) port and is
			probably not a digi driver issue.

		The dialog application to reproduce this problem is simply:

			dialog --inputbox "Enter date?" 9 40 "$( date )" 2> /dev/null

		This is dialog on a 7.4-RELEASE system, not the new dialog in 9.0-CURRENT.

David Boyd
Comment 2 Peter.Jeremy 2011-07-18 05:42:55 UTC
I have been doing some testing, bidirectionally transferring all
binary codes except xon and xoff between a pair of Digi ports and a
pair of motherboard com ports at 115,200bps.  (I'd like to test more
ports but I could only liberate 2 suitable null modem cables).

After transferring 10.8GB in each direction across each link (43GB
total), I have a total of 14 corrupt bytes reported.  All were
received on the motherboard com ports and the 9 errors I've captured
appear random.

-- 
Peter Jeremy
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:43 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2018-05-20 18:44:44 UTC
# 20160901: Remove digi(4)