Bug 158406 - [patch] update emulators/wine 1.3.21 -> 1.3.23
Summary: [patch] update emulators/wine 1.3.21 -> 1.3.23
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-28 20:50 UTC by David Naylor
Modified: 2011-07-19 22:26 UTC (History)
0 users

See Also:


Attachments
file.diff (3.74 KB, patch)
2011-06-28 20:50 UTC, David Naylor
no flags Details | Diff
wine.diff (3.60 KB, patch)
2011-07-06 16:18 UTC, David Naylor
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Naylor 2011-06-28 20:50:06 UTC
Update wine from 1.3.21 to 1.3.23, also add support for XInput2 (required for some games to run properly, relating to mouse warping) and properly handle the OpenAL option.

Fix: Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-06-28 21:39:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gerald

Fix synopsis and assign.
Comment 2 Alex Kozlov 2011-07-03 23:36:32 UTC
Hi, David

Please use USE_XORG+= xi, btw are You sure that freebsd xorg-server(1.7.7)
supports xinput2?
Also You can remove redudant ${OSVERSION} < 700041 check.

p.s. 1.3.23 have some nasty regressions in wine3d that can be observed in
Age of Mythology: the Titans Demo for example, so maybe You want to hold update
a little, Gerald.
On the other hand, this is wine we talking about, they always break something.


--
Adios
Comment 3 David Naylor 2011-07-06 16:18:47 UTC
On Monday 04 July 2011 00:36:32 Alex Kozlov wrote:
> Hi, David

Hi

> Please use USE_XORG+= xi, btw are You sure that freebsd xorg-server(1.7.7)
> supports xinput2?

I remember reading that Xorg-server 1.9 was the first to support XInput2.  
That said I am running xorg-server-1.7.7 and adding libXi fixes the mouse warp 
for me.  Emperically, I would say having libXi is enough to fix the problem, 
regardless of Xorg-server version.  

> Also You can remove redudant ${OSVERSION} < 700041 check.

Done, see attached

> p.s. 1.3.23 have some nasty regressions in wine3d that can be observed in
> Age of Mythology: the Titans Demo for example, so maybe You want to hold
> update a little, Gerald.
> On the other hand, this is wine we talking about, they always break
> something.

I agree.  There are probably some programs that work properly under 1.3.23. 
for example Civilization V.  
Comment 4 Alex Kozlov 2011-07-08 23:54:05 UTC
On Wed, Jul 06, 2011 at 05:18:47PM +0200, David Naylor wrote:
> On Monday 04 July 2011 00:36:32 Alex Kozlov wrote:
>> Please use USE_XORG+= xi, btw are You sure that freebsd xorg-server(1.7.7)
>> supports xinput2?
> I remember reading that Xorg-server 1.9 was the first to support XInput2.
> That said I am running xorg-server-1.7.7 and adding libXi fixes the mouse warp
> for me.  Emperically, I would say having libXi is enough to fix the problem,
> regardless of Xorg-server version.
I did some research and it seems that xinput2 appeared in xserver 1.7,
although issues with it still exists even in current version
(e.g. https://bugs.freedesktop.org/show_bug.cgi?id=30068). However I don't
think that disabling xinput2 is a good idea.

>> p.s. 1.3.23 have some nasty regressions in wine3d that can be observed in
>> Age of Mythology: the Titans Demo for example, so maybe You want to hold
>> update a little, Gerald.
>> On the other hand, this is wine we talking about, they always break
>> something.
> I agree.  There are probably some programs that work properly under 1.3.23.
> for example Civilization V.
Can You please update patch to 1.3.24?


--
Adios
Comment 5 gerald 2011-07-08 23:59:17 UTC
On Sat, 9 Jul 2011, Alex Kozlov wrote:
> Can You please update patch to 1.3.24?

I'll take care of that.  Let me apply David's original patch for 1.3.23
for now (this weekend), just leaving the X issue open which I'd like to
understand a bit better.

Gerald
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-07-09 00:15:51 UTC
gerald      2011-07-08 23:15:38 UTC

  FreeBSD ports repository

  Modified files:
    emulators/wine       Makefile distinfo pkg-plist 
  Log:
  Update to Wine 1.3.23.  This includes the following changes:
   - Support for stubless COM proxies on x86-64.
   - Builtin dxdiag now outputs real information.
   - Monochrome bitmap format in the DIB engine.
   - Beginnings of a true shell Explorer builtin.
   - A number of new D3DX9 functions.
   - More support for Indic text shaping.
   - Various bug fixes.
  
  Also fix pkg-plist with respect to the USE_OPENAL option.
  
  Remove an obsolete (pre FreeBSD 7.x) post-patch target. [1]
  
  PR:             158406
  Submitted by:   David Naylor <naylor.b.david@gmail.com>
  Reported by:    Alex Kozlov <spam@rm-rf.kiev.ua> [1]
  
  Revision  Changes    Path
  1.376     +3 -8      ports/emulators/wine/Makefile
  1.232     +2 -2      ports/emulators/wine/distinfo
  1.196     +5 -1      ports/emulators/wine/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Alex Kozlov 2011-07-09 06:41:00 UTC
On Sat, Jul 09, 2011 at 12:59:17AM +0200, Gerald Pfeifer wrote:
> On Sat, 9 Jul 2011, Alex Kozlov wrote:
>> Can You please update patch to 1.3.24?
> I'll take care of that.  Let me apply David's original patch for 1.3.23
> for now (this weekend),
Thanks.

> just leaving the X issue open which I'd like to > understand a bit better.
Technically, addition xi to USE_XORG just a formality, because libXi
already installed as a dependency for xserver, and wine's configure
autodetects it and enables xinput2. But You are right, disabling xinput2 or
not is somewhat difficult question that worth thinking about, especially
because we won't get xserver 1.9 and recent xinput fixes anytime soon.


--
Adios
Comment 8 Gerald Pfeifer freebsd_committer freebsd_triage 2011-07-19 22:25:51 UTC
State Changed
From-To: open->closed

Port has been updated a bit ago.