Bug 158748 - net/libvncserver won't compile
Summary: net/libvncserver won't compile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-09 01:10 UTC by Larry Rosenman
Modified: 2011-10-14 09:30 UTC (History)
0 users

See Also:


Attachments
libvncserver.diff.txt (697 bytes, text/plain; charset=us-ascii)
2011-07-10 01:11 UTC, Ryan Steinmetz
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Larry Rosenman freebsd_committer freebsd_triage 2011-07-09 01:10:07 UTC
===>  Building for libvncserver-0.9.8
/usr/bin/make  all-recursive
Making all in libvncserver
/bin/sh ../libtool --tag=CC    --mode=compile cc -DHAVE_CONFIG_H -I. -I.. -I.. -I../common   -I/usr/local/include  -O2 -pipe -fno-strict-aliasing -Wall -I/usr/local/include -I/usr/local/include -MT main.lo -MD -MP -MF .deps/main.Tpo -c -o main.lo main.c
mkdir .libs
 cc -DHAVE_CONFIG_H -I. -I.. -I.. -I../common -I/usr/local/include -O2 -pipe -fno-strict-aliasing -Wall -I/usr/local/include -I/usr/local/include -MT main.lo -MD -MP -MF .deps/main.Tpo -c main.c  -fPIC -DPIC -o .libs/main.o
main.c:1057:19: error: conio.h: No such file or directory
main.c:1061: error: conflicting types for 'gettimeofday'
/usr/include/sys/time.h:335: error: previous declaration of 'gettimeofday' was here
main.c: In function 'gettimeofday':
main.c:1062: error: 'SYSTEMTIME' undeclared (first use in this function)
main.c:1062: error: (Each undeclared identifier is reported only once
main.c:1062: error: for each function it appears in.)
main.c:1062: error: expected ';' before 't'
main.c:1063: warning: implicit declaration of function 'GetSystemTime'
main.c:1063: error: 't' undeclared (first use in this function)
*** Error code 1

Stop in /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8/libvncserver.
*** Error code 1

Stop in /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8.
*** Error code 1

Stop in /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8.
*** Error code 1

Stop in /usr/ports/net/libvncserver.

===>>> make failed for net/libvncserver
===>>> Aborting update

===>>> Update for net/libvncserver failed
===>>> Aborting update


===>>> You can restart from the point of failure with this command line:
       portmaster <flags> emulators/virtualbox-ose emulators/virtualbox-ose-kmod net/libvncserver net/vde2 sysutils/cdrtools textproc/libxslt security/libgcrypt security/libgpg-error
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-07-09 09:34:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bapt

Fix synopsis and assign.
Comment 2 Ryan Steinmetz 2011-07-09 18:44:50 UTC
Larry,

Do you have anything defined in /etc/make.conf?  Also, if you attempt to do the following, what do you get?:
cd /usr/ports/net/libvncserver && make
grep -r LIBVNCSERVER_HAVE_GETTIMEOFDAY work

I was able to confirm that libvncserver 0.9.8 does build for me on 8.2-R running both i386 and amd64.
-r

On (07/08/11 19:04), Larry Rosenman wrote:
> 
> >Number:         158748
> >Category:       ports
> >Synopsis:       libvncserver won't compile
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       medium
> >Responsible:    freebsd-ports-bugs
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Sat Jul 09 00:10:07 UTC 2011
> >Closed-Date:
> >Last-Modified:
> >Originator:     Larry Rosenman
> >Release:        FreeBSD 8.2-STABLE amd64
> >Organization:
> LERCTR Consulting
> >Environment:
> System: FreeBSD borg.lerctr.org 8.2-STABLE FreeBSD 8.2-STABLE #58: Fri Jul 8 14:29:00 CDT 2011 root@borg.lerctr.org:/usr/obj/usr/src/sys/BORG amd64
> 
> 
> >Description:
> ===>  Building for libvncserver-0.9.8
> /usr/bin/make  all-recursive
> Making all in libvncserver
> /bin/sh ../libtool --tag=CC    --mode=compile cc -DHAVE_CONFIG_H -I. -I.. -I.. -I../common   -I/usr/local/include  -O2 -pipe -fno-strict-aliasing -Wall -I/usr/local/include -I/usr/local/include -MT main.lo -MD -MP -MF .deps/main.Tpo -c -o main.lo main.c
> mkdir .libs
>  cc -DHAVE_CONFIG_H -I. -I.. -I.. -I../common -I/usr/local/include -O2 -pipe -fno-strict-aliasing -Wall -I/usr/local/include -I/usr/local/include -MT main.lo -MD -MP -MF .deps/main.Tpo -c main.c  -fPIC -DPIC -o .libs/main.o
> main.c:1057:19: error: conio.h: No such file or directory
> main.c:1061: error: conflicting types for 'gettimeofday'
> /usr/include/sys/time.h:335: error: previous declaration of 'gettimeofday' was here
> main.c: In function 'gettimeofday':
> main.c:1062: error: 'SYSTEMTIME' undeclared (first use in this function)
> main.c:1062: error: (Each undeclared identifier is reported only once
> main.c:1062: error: for each function it appears in.)
> main.c:1062: error: expected ';' before 't'
> main.c:1063: warning: implicit declaration of function 'GetSystemTime'
> main.c:1063: error: 't' undeclared (first use in this function)
> *** Error code 1
> 
> Stop in /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8/libvncserver.
> *** Error code 1
> 
> Stop in /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8.
> *** Error code 1
> 
> Stop in /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8.
> *** Error code 1
> 
> Stop in /usr/ports/net/libvncserver.
> 
> ===>>> make failed for net/libvncserver
> ===>>> Aborting update
> 
> ===>>> Update for net/libvncserver failed
> ===>>> Aborting update
> 
> 
> ===>>> You can restart from the point of failure with this command line:
>        portmaster <flags> emulators/virtualbox-ose emulators/virtualbox-ose-kmod net/libvncserver net/vde2 sysutils/cdrtools textproc/libxslt security/libgcrypt security/libgpg-error
> 
> >How-To-Repeat:
> >Fix:
> 
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> _______________________________________________
> freebsd-ports-bugs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
> To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"

-- 
Ryan Steinmetz
Rochester Institute of Technology
PGP: EF36 D45A 5CA9 28B1 A550  18CD A43C D111 7AD7 FAF2
Comment 3 Larry Rosenman freebsd_committer freebsd_triage 2011-07-09 20:56:54 UTC
$ cat /etc/make.conf
KERNCONF=BORG
INSTALL_NODEBUG=yes
LOGDIR=/var/log/exim
LOG_FILE_PATH="syslog:${LOGDIR}/%slog"
WITH_GECKO=firefox
WITHOUT_X11=yes
# added by use.perl 2011-01-18 14:40:11
PERL_VERSION=5.8.9
$

$ cd /usr/ports/net/libvncserver
$ grep -r LIBVNCSERVER_HAVE_GETTIMEOFDAY work
work/LibVNCServer-0.9.8/libvncserver/main.c:#ifndef
LIBVNCSERVER_HAVE_GETTIMEOFDAY
work/LibVNCServer-0.9.8/CMakeLists.txt:check_function_exists(gettimeofday 
  LIBVNCSERVER_HAVE_GETTIMEOFDAY)
work/LibVNCServer-0.9.8/rfb/rfbconfig.h:/* #undef
LIBVNCSERVER_HAVE_GETTIMEOFDAY */
work/LibVNCServer-0.9.8/rfb/rfbconfig.h.cmake:#cmakedefine
LIBVNCSERVER_HAVE_GETTIMEOFDAY  1
$

On Sat, July 9, 2011 12:44 pm, Ryan Steinmetz wrote:
> Larry,
>
> Do you have anything defined in /etc/make.conf?  Also, if you attempt to
> do the following, what do you get?:
> cd /usr/ports/net/libvncserver && make
> grep -r LIBVNCSERVER_HAVE_GETTIMEOFDAY work
>
> I was able to confirm that libvncserver 0.9.8 does build for me on 8.2-R
> running both i386 and amd64.
> -r
>
> On (07/08/11 19:04), Larry Rosenman wrote:
>>
>> >Number:         158748
>> >Category:       ports
>> >Synopsis:       libvncserver won't compile
>> >Confidential:   no
>> >Severity:       non-critical
>> >Priority:       medium
>> >Responsible:    freebsd-ports-bugs
>> >State:          open
>> >Quarter:
>> >Keywords:
>> >Date-Required:
>> >Class:          sw-bug
>> >Submitter-Id:   current-users
>> >Arrival-Date:   Sat Jul 09 00:10:07 UTC 2011
>> >Closed-Date:
>> >Last-Modified:
>> >Originator:     Larry Rosenman
>> >Release:        FreeBSD 8.2-STABLE amd64
>> >Organization:
>> LERCTR Consulting
>> >Environment:
>> System: FreeBSD borg.lerctr.org 8.2-STABLE FreeBSD 8.2-STABLE #58: Fri
>> Jul 8 14:29:00 CDT 2011 root@borg.lerctr.org:/usr/obj/usr/src/sys/BORG
>> amd64
>>
>>
>> >Description:
>> ===>  Building for libvncserver-0.9.8
>> /usr/bin/make  all-recursive
>> Making all in libvncserver
>> /bin/sh ../libtool --tag=CC    --mode=compile cc -DHAVE_CONFIG_H -I.
>> -I.. -I.. -I../common   -I/usr/local/include  -O2 -pipe
>> -fno-strict-aliasing -Wall -I/usr/local/include -I/usr/local/include -MT
>> main.lo -MD -MP -MF .deps/main.Tpo -c -o main.lo main.c
>> mkdir .libs
>>  cc -DHAVE_CONFIG_H -I. -I.. -I.. -I../common -I/usr/local/include -O2
>> -pipe -fno-strict-aliasing -Wall -I/usr/local/include
>> -I/usr/local/include -MT main.lo -MD -MP -MF .deps/main.Tpo -c main.c
>> -fPIC -DPIC -o .libs/main.o
>> main.c:1057:19: error: conio.h: No such file or directory
>> main.c:1061: error: conflicting types for 'gettimeofday'
>> /usr/include/sys/time.h:335: error: previous declaration of
>> 'gettimeofday' was here
>> main.c: In function 'gettimeofday':
>> main.c:1062: error: 'SYSTEMTIME' undeclared (first use in this function)
>> main.c:1062: error: (Each undeclared identifier is reported only once
>> main.c:1062: error: for each function it appears in.)
>> main.c:1062: error: expected ';' before 't'
>> main.c:1063: warning: implicit declaration of function 'GetSystemTime'
>> main.c:1063: error: 't' undeclared (first use in this function)
>> *** Error code 1
>>
>> Stop in
>> /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8/libvncserver.
>> *** Error code 1
>>
>> Stop in /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8.
>> *** Error code 1
>>
>> Stop in /usr/ports/net/libvncserver/work/LibVNCServer-0.9.8.
>> *** Error code 1
>>
>> Stop in /usr/ports/net/libvncserver.
>>
>> ===>>> make failed for net/libvncserver
>> ===>>> Aborting update
>>
>> ===>>> Update for net/libvncserver failed
>> ===>>> Aborting update
>>
>>
>> ===>>> You can restart from the point of failure with this command line:
>>        portmaster <flags> emulators/virtualbox-ose
>> emulators/virtualbox-ose-kmod net/libvncserver net/vde2
>> sysutils/cdrtools textproc/libxslt security/libgcrypt
>> security/libgpg-error
>>
>> >How-To-Repeat:
>> >Fix:
>>
>> >Release-Note:
>> >Audit-Trail:
>> >Unformatted:
>> _______________________________________________
>> freebsd-ports-bugs@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
>> To unsubscribe, send any mail to
>> "freebsd-ports-bugs-unsubscribe@freebsd.org"
>
> --
> Ryan Steinmetz
> Rochester Institute of Technology
> PGP: EF36 D45A 5CA9 28B1 A550  18CD A43C D111 7AD7 FAF2
>


-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 512-248-2683                 E-Mail: ler@lerctr.org
US Mail: 430 Valona Loop, Round Rock, TX 78681-3893
Comment 4 Ryan Steinmetz 2011-07-09 23:15:05 UTC
Your output differs from my 8.2-R box:

work/LibVNCServer-0.9.8/libvncserver/main.c:#ifndef LIBVNCSERVER_HAVE_GETTIMEOFDAY
work/LibVNCServer-0.9.8/CMakeLists.txt:check_function_exists(gettimeofday    LIBVNCSERVER_HAVE_GETTIMEOFDAY)
work/LibVNCServer-0.9.8/rfb/rfbconfig.h:#ifndef LIBVNCSERVER_HAVE_GETTIMEOFDAY 
work/LibVNCServer-0.9.8/rfb/rfbconfig.h:#define LIBVNCSERVER_HAVE_GETTIMEOFDAY  1 
work/LibVNCServer-0.9.8/rfb/rfbconfig.h.cmake:#cmakedefine LIBVNCSERVER_HAVE_GETTIMEOFDAY  1 

That missing define (#define LIBVNCSERVER_HAVE_GETTIMEOFDAY  1) is the source of the build error.

You would try temporarily renaming make.conf (although nothing immediately jumps out at me as being a source of your problem) and trying the build again.
Comment 5 Ryan Steinmetz 2011-07-10 01:11:36 UTC
The attached patch should take care of the issue Larry was running into.  -lws2_32 being in LIBS was causing configure to incorrectly decide that gettimeofday() didn't exist on his system.

Appending --without-ipv6 to CONFIGURE_ARGS also causes this issue not to surface, although this should not be required with the attached patch.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-10-14 09:20:23 UTC
bapt        2011-10-14 08:20:09 UTC

  FreeBSD ports repository

  Modified files:
    net/libvncserver     Makefile distinfo 
  Added files:
    net/libvncserver/files patch-configure 
  Log:
  - Upgrade to 0.9.8.1
  - Fix some problem detecting gettimeofday [1]
  
  PR:             ports/158748 [1]
  Submitted by:   Larry Rosenman <ler@lerctr.org> [1]
  Patch by:       Ryan Steinmetz <rpsfa@rit.edu> [1]
  
  Revision  Changes    Path
  1.18      +1 -1      ports/net/libvncserver/Makefile
  1.11      +2 -2      ports/net/libvncserver/distinfo
  1.1       +10 -0     ports/net/libvncserver/files/patch-configure (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Baptiste Daroussin freebsd_committer freebsd_triage 2011-10-14 09:20:25 UTC
State Changed
From-To: open->closed

Committed. Thanks!