Perl 5.14 changes format of compiled regexps. This patch amends the pattern awstats uses to parse
compiled regexps to cater for the new 5.14 format.
The patch was taken from the upstream bug tracker:
I've smoke tested this and it resolves the issue.
Port maintainer (firstname.lastname@example.org) is cc'd.
Generated with FreeBSD Port Tools 0.99
Maintainer of www/awstats,
Please note that PR ports/158837 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
Edwin Groothuis via the GNATS Auto Assign Tool
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Patch is still in the "open" state. Do you know if developers are going
to commit it? I am not very happy with non-official patches.
On 12/07/2011 16:17, Alex Samorukov wrote:
> Patch is still in the "open" state. Do you know if developers are going
> to commit it? I am not very happy with non-official patches.
I think unofficial patches are perfectly acceptable especially when a)
they unbreak a port, b) are extremely trivial and c) can be removed when
the bug is actually fixed upstream and a new release is cut.
But it's your port, so it's your call. I'm quite happy to run it as a
local patch, but thought other users of the port running with Perl 5.14
would like to benefit from it.
Agree with your arguments.
Ok, i checked CVS and it seems that devs are not very active last
months. I`m accepting this patch, thank you for commit. I hope it will
not break anything else.
I'll take it
beech 2011-07-14 16:42:10 UTC
FreeBSD ports repository
- Perl 5.14 changes format of compiled regexps.
This update amends the pattern awstats uses to parse
compiled regexps to cater for the new 5.14 format
Submitted by: Jase Thew <email@example.com>
Approved by: Alex Samorukov <firstname.lastname@example.org> (maintainer)
Revision Changes Path
1.46 +1 -1 ports/www/awstats/Makefile
1.5 +23 -3 ports/www/awstats/files/patch-wwwroot-cgi-bin-awstats.pl
email@example.com mailing list
To unsubscribe, send any mail to "firstname.lastname@example.org"
I just wanted to say thanks for adding the patch to the port (I'm the =
original author of the fix). I was actually considering sending a PR =
about it myself after I posted my solution to the awstats bug tracker, =
but decided against it for maintainer's reasons. Unfortunately, it seems =
awstats development has practically ended, making it necessary to =
maintain local patches like this.