Bug 158888 - [patch] devel/ccache: relax EXTRA_COMPILERS
[patch] devel/ccache: relax EXTRA_COMPILERS
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Any Any
: Normal Affects Only Me
Assigned To: Emanuel Haupt
Depends on:
  Show dependency treegraph
Reported: 2011-07-14 13:10 UTC by inyaoo
Modified: 2011-08-03 19:20 UTC (History)
0 users

See Also:

a.diff (1.47 KB, patch)
2011-07-14 13:10 UTC, inyaoo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description inyaoo 2011-07-14 13:10:09 UTC
Before ccache-update-links was added the port advertised EXTRA_COMPILERS
make/env variable and didn't apply any checks to its value. As the
changes to them are not mentioned in either commit log or UPDATING relax
checks to not break valid user configurations.

- add every known compiler from PATH[1], i.e. do not hardcode search path
- restore EXTRA_COMPILERS to the list of known compilers[2]

[1] a user (root in this case) is responsible for setting safe PATH
[2] as it can be replaced by CCACHE_COMPILERS defined in make.conf
    EXTRA_COMPILERS can be phased out *with* an entry in UPDATING
Comment 1 Edwin Groothuis freebsd_committer 2011-07-14 13:10:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 inyaoo 2011-07-14 13:27:23 UTC
Pan Tsu <inyaoo@gmail.com> writes:

> - restore EXTRA_COMPILERS to the list of known compilers[2]

Oops, EXTRA_COMPILERS, the make variable

A more short example that used to work

  $ ln -s /usr/bin/gcc /path/to/foo/foo
  $ export PATH=$CCACHE:/path/to/foo:$PATH
  $ make install EXTRA_COMPILERS="foo"
  $ CCACHE_LOGFILE=/dev/tty foo blah.c
Comment 3 dfilter freebsd_committer 2011-08-03 19:18:01 UTC
ehaupt      2011-08-03 18:17:53 UTC

  FreeBSD ports repository

  Modified files:
    devel/ccache         Makefile 
    devel/ccache/files   ccache-update-links.sh.in 
  Restore the possibility to define EXTRA_COMPILERS which must reside in $PATH.
  PR:             158888
  Submitted by:   Pan Tsu <inyaoo@gmail.com>
  Revision  Changes    Path
  1.63      +2 -0      ports/devel/ccache/Makefile
  1.2       +2 -2      ports/devel/ccache/files/ccache-update-links.sh.in
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Emanuel Haupt freebsd_committer 2011-08-03 19:18:23 UTC
State Changed
From-To: open->closed

Sorry for the delay. Committed, thanks!