Bug 159056 - [PATCH]math/suitesparse: fix build on sparc64, miscellaneous clean-ups
Summary: [PATCH]math/suitesparse: fix build on sparc64, miscellaneous clean-ups
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Maho Nakata
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-20 08:00 UTC by Brendan Fabeny
Modified: 2011-07-20 17:32 UTC (History)
0 users

See Also:


Attachments
file.diff (13.12 KB, patch)
2011-07-20 08:00 UTC, Brendan Fabeny
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Fabeny freebsd_committer freebsd_triage 2011-07-20 08:00:22 UTC
- add LICENSE
- fix whitespace and reduce make verbosity, wrap some long lines
- switch from USE_BLAS to WITH_BLAS, and allow the user to set this, following the recent trend in other ports (we should consolidate the macros for
this in a central makefile at some point)
- remove BROKEN
- small grammar fix to RESTRICTED
- follow bsd.lib.mk in using -fPIC by default only on sparc64
- now that we have DT_NEEDED tags in our math/blas libraries, remove the unneeded FORTRANRUNTIME (I'll add tags to math/atlas soon)
- add PTHREAD_CFLAGS and PTHREAD_LIBS, in case these become non-trivial again on some ARCHs
- prefer the canonical PICFLAG to FPIC
- simplify the post-patch target by patching the static and shared sources identically (differentiate between the two by setting PICFLAG to the appropriate value in the MAKE_ENV); because AR and RANLIB additions were necessary, simply use sed(1) rather than re-rolling many of the patches, and fashioning new ones
- simplify the do-build and do-install targets by adding two loops, and removing the separate staging areas and unnecessary sed/ls calls
- canonicalize do-build target, to honor MAKE_ARGS and _MAKE_JOBS
- avoid the mixing of toolchains that broke the build on sparc64 by using ${LD} (set to ${LOCALBASE}/bin/ld by USE_FORTRAN, which implies USE_BINUTILS) instead of "ld", ${AR} instead of ar, and ${RANLIB} instead of ranlib, and respecting ${CC}
- prefer <string> to <string.h> for .cpp

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-20 08:00:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->maho

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-07-20 17:17:44 UTC
bf          2011-07-20 16:17:35 UTC

  FreeBSD ports repository

  Modified files:
    math/suitesparse     Makefile 
    math/suitesparse/files patch-SPQR+Source+spqr_factorize.cpp 
                           patch-UFconfig+UFconfig.mk 
  Removed files:
    math/suitesparse/files patch-CHOLMOD+Lib+Makefile 
                           patch-CSparse+Lib+Makefile 
                           patch-CSparse3+Lib+Makefile 
  Log:
  Avoid the mixing of toolchains that broke the sparc64 build;
  miscellaneous clean-ups
  
  PR:             159056
  Approved by:    maho
  
  Revision  Changes    Path
  1.38      +61 -84    ports/math/suitesparse/Makefile
  1.5       +0 -11     ports/math/suitesparse/files/patch-CHOLMOD+Lib+Makefile (dead)
  1.2       +0 -11     ports/math/suitesparse/files/patch-CSparse+Lib+Makefile (dead)
  1.2       +0 -11     ports/math/suitesparse/files/patch-CSparse3+Lib+Makefile (dead)
  1.2       +1 -1      ports/math/suitesparse/files/patch-SPQR+Source+spqr_factorize.cpp
  1.10      +2 -68     ports/math/suitesparse/files/patch-UFconfig+UFconfig.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Brendan Fabeny freebsd_committer freebsd_triage 2011-07-20 17:32:29 UTC
State Changed
From-To: open->closed

Committed. Thanks!