Bug 159075 - [PATCH]math/arpack: fix sparc64 build, overhaul
Summary: [PATCH]math/arpack: fix sparc64 build, overhaul
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stephen Montgomery-Smith
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 07:30 UTC by Brendan Fabeny
Modified: 2011-07-21 21:30 UTC (History)
0 users

See Also:


Attachments
file.diff (10.03 KB, patch)
2011-07-21 07:30 UTC, Brendan Fabeny
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Fabeny freebsd_committer freebsd_triage 2011-07-21 07:30:12 UTC
- Fix PATCH_SITES, and update to version 3 of Kloeckner's arscnd patch
- Embarrassingly, patch.tar.gz was being unpacked into the wrong directory, and so was not being applied.  Fix this.
- Remove extra USE_LDCONFIG; fix whitespace; remove unnecessary quotes and standardize on WITH_BLAS/BLAS; remove unnecessary WRKSRC_SHARED variable; unpack patch.tar.gz and compress docs in post-extract
- Simplify post-patch by unifying static and shared cases, now differentiated by issuing appropriate values for PICFLAG and home in MAKE_ENV
- Respect AR, RANLIB, LDFLAGS, etc. in ARmake.inc, remove erroneous value for LAPACKLIB; rather than re-rolling the patch, just use sed(1)
- Always install arpack.h
- Respect LD (this mixing of toolchains broke the sparc64 build, and others)
- Add tests (regression tests are disabled by default because some i386 versions hang on amd64 tinderboxes)
- adjust second.f patch after the second -> arscnd name change

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-21 07:30:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stephen

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-07-21 21:19:40 UTC
stephen     2011-07-21 20:19:33 UTC

  FreeBSD ports repository

  Modified files:
    math/arpack          Makefile distinfo pkg-plist 
    math/arpack/files    patch-UTIL+second.f 
  Removed files:
    math/arpack/files    patch-ARmake.inc 
  Log:
  - Fix PATCH_SITES, and update to version 3 of Kloeckner's arscnd patch.
  - Fix patch.tar.gz being unpacked into the wrong directory.
  - Respect AR, RANLIB, LD, LDFLAGS, etc. in ARmake.inc.
  - Fix install of arpack.h.
  - Fix broken sparc64 build.
  - Add tests.
  - Various other cleanups.
  
  PR:             ports/159075
  Submitted by:   bf
  Approved by:    maho (mentor, implicit)
  
  Revision  Changes    Path
  1.23      +99 -49    ports/math/arpack/Makefile
  1.7       +2 -2      ports/math/arpack/distinfo
  1.4       +0 -61     ports/math/arpack/files/patch-ARmake.inc (dead)
  1.2       +2 -2      ports/math/arpack/files/patch-UTIL+second.f
  1.6       +1 -1      ports/math/arpack/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2011-07-21 21:20:03 UTC
State Changed
From-To: open->closed

Committed.  Thank you for doing such careful work.