Bug 159792 - [patch] USB HID devices support for x11-drivers/xf86-input-mouse
Summary: [patch] USB HID devices support for x11-drivers/xf86-input-mouse
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-15 15:50 UTC by Alexander Motin
Modified: 2015-01-14 23:05 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Motin freebsd_committer freebsd_triage 2011-08-15 15:50:05 UTC
Now we have no support for pointing devices with absolute coordinates, such as touch screens or digitizers. Their support via ums(4) and sysmouse is problematic because they support only relative pointer coordinates.

Fix: 

These patches restores disabled USB HID devices support in xf86-input-mouse:
 http://people.freebsd.org/~mav/patch-zz-input-mouse9 - for 1.6.0
 http://people.freebsd.org/~mav/patch-zz-input-mouse9.1.7.1 - for 1.7.1

Patches support both relative and absolute pointing devices and tested with mouses, digitizers and touch-screens. Here is related thread in x11 mailing list:
 http://docs.freebsd.org/cgi/mid.cgi?4E255F64.30608

Patches use existing for a long time libusbhid interface and should work for all FreeBSD versions since at least 5.1. Since that API came from NetBSD, it may also work for other BSDs also.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-08-16 00:30:01 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Fix synopsis and assign.
Comment 2 Niclas Zeising freebsd_committer freebsd_triage 2013-06-27 09:16:12 UTC
State Changed
From-To: open->feedback

Is this still releveant with the latest xorg?
Comment 3 Alexander Motin freebsd_committer freebsd_triage 2013-06-27 12:26:22 UTC
I don't think the patch will apply to the present version of the driver, 
but probably I could port it if somebody with contacts in Xorg could 
upstream it.

-- 
Alexander Motin
Comment 4 Niclas Zeising freebsd_committer freebsd_triage 2013-06-27 12:51:41 UTC
On 06/27/13 13:30, Alexander Motin wrote:
>  I don't think the patch will apply to the present version of the driver, 
>  but probably I could port it if somebody with contacts in Xorg could 

I can try to push the patch upstream, if the issue is still relevant.
Regards!
-- 
Niclas Zeising
Comment 5 Alexander Motin freebsd_committer freebsd_triage 2013-06-27 13:01:13 UTC
On 27.06.2013 14:51, Niclas Zeising wrote:
> On 06/27/13 13:30, Alexander Motin wrote:
>>   I don't think the patch will apply to the present version of the driver,
>>   but probably I could port it if somebody with contacts in Xorg could
>
> I can try to push the patch upstream, if the issue is still relevant.

OK, I'll update software on my touch-screen netbook and see what has 
changes there.

-- 
Alexander Motin
Comment 6 Niclas Zeising freebsd_committer freebsd_triage 2013-06-27 13:06:04 UTC
On 06/27/13 14:01, Alexander Motin wrote:
> On 27.06.2013 14:51, Niclas Zeising wrote:
>> On 06/27/13 13:30, Alexander Motin wrote:
>>>   I don't think the patch will apply to the present version of the
>>> driver,
>>>   but probably I could port it if somebody with contacts in Xorg could
>>
>> I can try to push the patch upstream, if the issue is still relevant.
> 
> OK, I'll update software on my touch-screen netbook and see what has
> changes there.
> 

Thank you, that would be awesome!
Regards!
-- 
Niclas Zeising
Comment 7 Alexander Motin freebsd_committer freebsd_triage 2013-06-28 13:45:34 UTC
On 27.06.2013 15:06, Niclas Zeising wrote:
> On 06/27/13 14:01, Alexander Motin wrote:
>> On 27.06.2013 14:51, Niclas Zeising wrote:
>>> On 06/27/13 13:30, Alexander Motin wrote:
>>>>    I don't think the patch will apply to the present version of the
>>>> driver,
>>>>    but probably I could port it if somebody with contacts in Xorg could
>>>
>>> I can try to push the patch upstream, if the issue is still relevant.
>>
>> OK, I'll update software on my touch-screen netbook and see what has
>> changes there.
>
> Thank you, that would be awesome!

Here is patch for current (1.9.0) port version (addition to present port 
patches). Changes from previous version mostly due to code formatting 
changes in upstream:
http://people.freebsd.org/~mav/patch-src-bsd_mouse.c2

-- 
Alexander Motin
Comment 8 Niclas Zeising freebsd_committer freebsd_triage 2013-07-02 14:21:38 UTC
State Changed
From-To: feedback->open

Feedback recieved.  Working on integrating the updated patch.
Comment 9 Niclas Zeising freebsd_committer freebsd_triage 2013-07-05 11:33:03 UTC
State Changed
From-To: open->analyzed

The patch is in the xorg-dev repo, awaiting some more testing before it is 
merged.  A discussion with upstream on how to integrate this patch upstream has 
begun.
Comment 10 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-01-14 23:05:26 UTC
The patch is in the Ports tree.