Bug 161837 - [libdisk] [patch] sysinstall(8) has a 32 disk limit
Summary: [libdisk] [patch] sysinstall(8) has a 32 disk limit
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-sysinstall (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-20 17:20 UTC by Tim Brody
Modified: 2015-11-10 09:07 UTC (History)
0 users

See Also:

Attachments
file.diff (2.00 KB, patch)
2011-10-20 17:20 UTC, Tim Brody 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Brody 2011-10-20 17:20:05 UTC 
sysinstall calls libdisk/Disk_Names that has a hard-limit of 32 disk
devices. On systems (e.g. Sun X4540) with more disks than this some
drives will be silently ignored. On the X4540 the missing drives include
the 4 bootable devices, making it impossible to install with sysinstall/
fdisk (hence severity=high).

This problem was first identified 10 years ago when the number was bumped
from 20 to 32 - http://www.cz.freebsd.org/pub/FreeBSD-cvs/gnats/conf/24503.

Further (but unpatched), sysinstall/devices.c does not free the contents
of the disks array so will cause a memory leak.

Fix: Apply attached patch to libdisk, recompile/reinstall libdisk and sysinstall.

Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-10-20 20:34:42 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-sysinstall

reclassify and assign.
Comment 2 Enji Cooper freebsd_committer freebsd_triage 2015-11-10 09:07:45 UTC 
sysinstall has been replaced by bsdinstall in FreeBSD 9.x. Closing.