Bug 162496 - sysutils/zfs-periodic periodic script error
Summary: sysutils/zfs-periodic periodic script error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-12 03:50 UTC by basarevych
Modified: 2012-01-06 22:00 UTC (History)
0 users

See Also:


Attachments
zfs-periodic.patch (375 bytes, patch)
2011-12-08 08:02 UTC, basarevych
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description basarevych 2011-11-12 03:50:04 UTC
Script /usr/local/etc/periodic/monthly/000.zfs-snapshot contains check if it enabled or not. Current version checks for $daily_zfs_snapshot_enable instead of $weekly_zfs_snapshot_enable variable.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-12 03:50:12 UTC
Maintainer of sysutils/zfs-periodic,

Please note that PR ports/162496 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162496

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-12 03:50:14 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 basarevych 2011-11-12 06:24:11 UTC
Sorry in the PR is a mistake:
instead of /usr/local/etc/periodic/monthly/000.zfs-snapshot read
/usr/local/etc/periodic/weekly/000.zfs-snapshot
Comment 4 peter 2011-11-12 19:46:28 UTC
I have no objection to the fix but can't se a patch or anything?

On Nov 12, 2011, at 4:50 AM, Edwin Groothuis wrote:

> Maintainer of sysutils/zfs-periodic,
> 
> Please note that PR ports/162496 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162496
> 
> -- 
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Comment 5 basarevych 2011-12-08 08:02:59 UTC
Here is the patch. I created it in
/usr/ports/sysutils/zfs-periodic/work/zfs-periodic-1.0 after doing
make extract.

I hope I did it right.
Comment 6 Eitan Adler freebsd_committer freebsd_triage 2011-12-25 17:06:35 UTC
State Changed
From-To: feedback->open

Maintainer has approved.
Comment 7 Michael Scheidell freebsd_committer freebsd_triage 2012-01-06 21:43:51 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it
Comment 8 Michael Scheidell freebsd_committer freebsd_triage 2012-01-06 21:59:06 UTC
State Changed
From-To: open->closed

Committed, Thanks
Comment 9 dfilter service freebsd_committer freebsd_triage 2012-01-06 21:59:06 UTC
scheidell    2012-01-06 21:58:57 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/zfs-periodic Makefile pkg-message 
  Added files:
    sysutils/zfs-periodic/files patch-zfs-snapshot 
  Log:
  - fix weekly/periodic script.  should have been 'weekly' was 'daily'
  
  PR:             ports/162496
  Submitted by:   basarevych@gmail.com
  Approved by:    peter@pean.org (maintainer), gabor (mentor, implicit)
  
  Revision  Changes    Path
  1.2       +1 -0      ports/sysutils/zfs-periodic/Makefile
  1.1       +11 -0     ports/sysutils/zfs-periodic/files/patch-zfs-snapshot (new)
  1.2       +0 -1      ports/sysutils/zfs-periodic/pkg-message
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"