Bug 163167 - port devel/git does not install scripts with executable bit
port devel/git does not install scripts with executable bit
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Wesley Shields
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-10 17:30 UTC by idefix
Modified: 2011-12-18 16:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description idefix 2011-12-10 17:30:11 UTC
If git is installed with the option contrib modules a script to send email if someone pushes changes to the repository is installed:
/usr/local/share/git-core/contrib/hooks/post-receive-email

This script has no executable bit that causes after every update of git problems with the hook. The file:
/usr/ports/devel/git/work/git-1.7.8/contrib/hooks/post-receive-email

has the executable permisson flag.
So it seems to be removed on the install step of ports.

Fix: 

Install the contrib module without removing the executable bit.
How-To-Repeat: Install devel/git with contrib option enabled.
Comment 1 Edwin Groothuis freebsd_committer 2011-12-10 17:30:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2011-12-18 16:17:42 UTC
wxs         2011-12-18 16:17:32 UTC

  FreeBSD ports repository

  Modified files:
    devel/git            Makefile pkg-plist 
  Log:
  Switch to installing contrib files using COPYTREE_BIN instead of
  COPYTREE_SHARE. The documentation in the hooks says you should set
  executable permissions on the hook before setting it up in a repository,
  but if you update git the permissions get reset. Just install the entire
  contrib directory with executable bit set.
  
  What we really need is a "COPYTREE_ASIS" that just leaves the permissions as
  they are.
  
  Note I am intentionally not bumping PORTREVISION as this is a minor change
  and this port gets updated fairly regularly.
  
  PR:             ports/163167
  Submitted by:   Matthias Fechner <idefix@fechner.net>
  
  Revision  Changes    Path
  1.122     +1 -1      ports/devel/git/Makefile
  1.87      +2 -2      ports/devel/git/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Wesley Shields freebsd_committer 2011-12-18 16:18:14 UTC
State Changed
From-To: open->closed

Committed. You will have to manually rebuild and reinstall git to get 
this change or wait until the next significant update. Thanks!