Bug 163529 - [patch] net/avahi-autoipd and net/avahi-libdns GIDs collide with Samba WKRID
Summary: [patch] net/avahi-autoipd and net/avahi-libdns GIDs collide with Samba WKRID
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-22 11:30 UTC by Anthony Chavez
Modified: 2011-12-28 21:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.07 KB, patch)
2011-12-22 11:30 UTC, Anthony Chavez
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Chavez 2011-12-22 11:30:14 UTC
Similarly to ports/105122, the GID chosen for the avahi-autoipd group (546) is the same as the Samba well-known RID for the local Guests group, as described here:

http://samba.org/samba/docs/man/Samba-HOWTO-Collection/groupmapping.html#WKURIDS

Fix: The patch attached to this PR addresses the issue in both ports, and I will be submitting a separate PR to address the issue of reserving well-known user default RIDs so that this problem can be avoided in the future.

It should be noted in both PRs that with the exception of 3 UIDs, it is only GIDs that should be reserved.  Also, having equivalent UIDs and GIDs is not strictly necessary, and seems to be done purely for aesthetics in most cases.  My patch carries on this convention.

Also, both ports create and use the same user (avahi-autoipd) with the same UID.  It's assumed that this is intentional, but the pkg-install scripts differ in that the user is given a different GECOS name depending on which port is installed.  I've taken the liberty of correcting this as well.


Patch attached with submission follows:
How-To-Repeat: sudo portmaster net/avahi-autoipd
Comment 1 Edwin Groothuis freebsd_committer 2011-12-22 11:30:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Anthony Chavez 2011-12-22 11:45:29 UTC
This is a multi-part message in MIME format.
Comment 3 Joe Marcus Clarke freebsd_committer 2011-12-28 21:01:50 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer 2011-12-28 21:01:58 UTC
marcus      2011-12-28 21:01:44 UTC

  FreeBSD ports repository

  Modified files:
    .                    GIDs 
    net/avahi-autoipd    pkg-install 
    net/avahi-libdns     pkg-install 
  Log:
  Use a new GID for avahi-autoipd to avoid a conflict with the Samba well-known RID
  for the local Guests group.
  
  PR:             163529
  Submitted by:   Anthony Chavez <acc@hexadecagram.org>
  
  Revision  Changes    Path
  1.162     +2 -1      ports/GIDs
  1.2       +1 -1      ports/net/avahi-autoipd/pkg-install
  1.2       +1 -1      ports/net/avahi-libdns/pkg-install
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"