Bug 163667 - [maintainer-update] unbreak x11-wm/mcwm for gcc46
Summary: [maintainer-update] unbreak x11-wm/mcwm for gcc46
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
Depends on:
Reported: 2011-12-28 13:00 UTC by jakub_lach
Modified: 2011-12-28 16:50 UTC (History)
0 users

See Also:

file.diff (533 bytes, patch)
2011-12-28 13:00 UTC, jakub_lach
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jakub_lach 2011-12-28 13:00:23 UTC
Easing the life for those forcing gcc46.

Fix: Patch attached with submission follows:
Comment 1 Chris Rees freebsd_committer 2011-12-28 13:10:28 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 2 Chris Rees freebsd_committer 2011-12-28 13:33:53 UTC
State Changed
From-To: open->feedback


Not a fan of the redefining install targets with a patch; more standard 
to use do-install in the port's Makefile. Also deinstall target is never 
called from ports. 

Also, I've replaced the patch with a few seds; it's a bit simpler now. 

Comment 3 dfilter service freebsd_committer 2011-12-28 16:42:13 UTC
crees       2011-12-28 16:42:05 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/mcwm          Makefile 
    x11-wm/mcwm/files    patch-Makefile 
  - Fix build with gcc46
  - Tidy install code; use do-install instead of patching Makefile
  PR:             ports/163667
  Submitted by:   Jakub Lach <jakub_lach@mailplus.pl> (maintainer)
  Revision  Changes    Path
  1.8       +9 -0      ports/x11-wm/mcwm/Makefile
  1.5       +13 -27    ports/x11-wm/mcwm/files/patch-Makefile
cvs-all@freebsd.org mailing list
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Chris Rees freebsd_committer 2011-12-28 16:43:31 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!