Bug 163724 - [mwl] [patch] NULL check before dereference
Summary: [mwl] [patch] NULL check before dereference
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: wireless (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-wireless (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-30 22:10 UTC by Philippe Saint-Pierre
Modified: 2016-05-17 21:05 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (804 bytes, patch)
2011-12-30 22:10 UTC, Philippe Saint-Pierre 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Saint-Pierre 2011-12-30 22:10:12 UTC 
In the Marvell wifi driver, there are dereferences attempts occuring before the NULL check.

Fix: Patch included.  Basically moves the NULL check to before any dereferences attempts.

Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-12-30 22:14:19 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-wireless

Over to maintainer(s).
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2016-05-17 21:05:44 UTC 
The NULL check for this pointer is not needed (because it's the address of an array member) and was removed in r300077.