Bug 166254 - [PATCH] mail/mailscanner: Update to correct TNEF bug.
Summary: [PATCH] mail/mailscanner: Update to correct TNEF bug.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 19:20 UTC by Kevin Kobb
Modified: 2012-03-21 21:10 UTC (History)
0 users

See Also:


Attachments
file.diff (6.65 KB, patch)
2012-03-19 19:20 UTC, Kevin Kobb
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Kobb 2012-03-19 19:20:08 UTC
Recent MailScanner update introduce a bug in the TNEF.pm module that made unpacking MS TNEF attachments produce errors. This is due the process used to create the temp directories.

Fix: Apply the attached patch.

Patch attached with submission follows:
How-To-Repeat: Install the MailScanner port and send a message with a MS TNEF attachment.
Comment 1 Edwin Groothuis freebsd_committer 2012-03-19 19:20:20 UTC
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2012-03-19 19:20:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

crees@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 3 Chris Rees freebsd_committer 2012-03-19 21:12:30 UTC
State Changed
From-To: open->analyzed

Interesting take, though I'm not sure I like the SUB_FILES patch 
approach-- I'm really sorry your private mail with the patch had slipped 
below my radar.  I'll prepare a slightly modified patch for your 
approval very shortly.
Comment 4 dfilter service freebsd_committer 2012-03-21 21:08:11 UTC
crees       2012-03-21 21:08:02 UTC

  FreeBSD ports repository

  Modified files:
    mail/mailscanner     Makefile 
    mail/mailscanner/files CHANGES.port README.FreeBSD.port 
                           mailscanner.in mta.in pkg-install.in 
  Added files:
    mail/mailscanner/files MailScanner.8.in 
                           patch-lib__MailScanner__TNEF.pm 
  Removed files:
    mail/mailscanner/files MailScanner.8 
  Log:
  - Fix MS TNEF unpacking
  
  - Use substitution in MailScanner.8 to update version
  
  - Correct handling of WITHOUT_SPAMASSASSIN_SYMLINK in pkg-install
  
  PR:             ports/166254
  Submitted by:   Kevin Kobb (kkobb@skylinecorp.com) (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.100     +7 -8      ports/mail/mailscanner/Makefile
  1.29      +6 -0      ports/mail/mailscanner/files/CHANGES.port
  1.2       +0 -12     ports/mail/mailscanner/files/MailScanner.8 (dead)
  1.1       +12 -0     ports/mail/mailscanner/files/MailScanner.8.in (new)
  1.5       +7 -14     ports/mail/mailscanner/files/README.FreeBSD.port
  1.8       +1 -1      ports/mail/mailscanner/files/mailscanner.in
  1.8       +1 -1      ports/mail/mailscanner/files/mta.in
  1.1       +20 -0     ports/mail/mailscanner/files/patch-lib__MailScanner__TNEF.pm (new)
  1.2       +3 -2      ports/mail/mailscanner/files/pkg-install.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Chris Rees freebsd_committer 2012-03-21 21:09:24 UTC
State Changed
From-To: analyzed->closed

Committed.  Thanks!  I've kept your manpage update-- I misread it as 
munging a patch before (I've had a bad week...).  I've also improved the 
handling of the spamassassin-symlink script part too; installing from a 
package it now works correctly as well.