Bug 169218 - [PATCH] print/acroreadwrapper: fix usage of ${SRC_BASE} before it is defined
Summary: [PATCH] print/acroreadwrapper: fix usage of ${SRC_BASE} before it is defined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 00:40 UTC by Jason Helfman
Modified: 2012-06-20 09:00 UTC (History)
1 user (show)

See Also:


Attachments
acroreadwrapper-0.0.20110920.patch (945 bytes, patch)
2012-06-19 00:40 UTC, Jason Helfman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Helfman freebsd_committer 2012-06-19 00:40:21 UTC
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

pet portlint for whitespace

Port maintainer (hrs@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer 2012-06-19 00:41:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->hrs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jason Helfman freebsd_committer 2012-06-19 01:34:31 UTC
This bit is defined before bsd.port.pre.mk is included:
MAKE_ENV=	KMODDIR=${KMODDIR} SYSDIR=${SRC_BASE}/sys DESTDIR=${PREFIX}/

-jgh

-- 
Jason Helfman
FreeBSD Committer | http://people.freebsd.org/~jgh | The Power To Serve
Comment 3 dfilter service freebsd_committer 2012-06-20 08:52:27 UTC
hrs         2012-06-20 07:52:17 UTC

  FreeBSD ports repository

  Modified files:
    print/acroreadwrapper Makefile 
  Log:
  Style fix: include bsd.port.pre.mk before using SRC_BASE.
  
  PR:             ports/169218
  Submitted by:   jgh
  
  Revision  Changes    Path
  1.18      +4 -2      ports/print/acroreadwrapper/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Hiroki Sato freebsd_committer 2012-06-20 08:54:46 UTC
State Changed
From-To: open->closed

Committed.