Bug 169306 - [Maintainer Update] Minor bug fixes to sysutils/bsdconfig
[Maintainer Update] Minor bug fixes to sysutils/bsdconfig
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Wesley Shields
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-21 22:50 UTC by Devin Teske
Modified: 2012-06-22 02:50 UTC (History)
0 users

See Also:


Attachments
file.diff (1.06 KB, patch)
2012-06-21 22:50 UTC, Devin Teske
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Teske freebsd_committer 2012-06-21 22:50:12 UTC
When editing a user's password or account expiration property, choosing cancel or pressing ESC while editing the value manually would cause the value to be blanked rather than preserved. This has been fixed and pressing ESC (or choosing cancel) now preserves the value as expected.

Executing "bsdconfig foo" when LANG is set to "EN_US.ISO8859-1" produces a non-i18n-compatible error message: "bsdconfig: foo: not found" (when it should produce: "bsdconfig: foo: NOT FOUND"). This has been fixed by adding the appropriate i18n messages and changing the code to use them.

Executing "bsdconfig -h" when LANG is set to an unknown language (for which there are no bsdconfig localized language files), the output did not display appropriately. This has been fixed.

Executing "bsdconfig timezone -h" (for example) when LANG is set to an unkown language had similar issues to the above.

Fix: All problems have been patched by code-changes in the distribution snapshot (referenced/pulled down by new port Makefile).

Patch attached with submission follows:
How-To-Repeat: Execute "bsdconfig useredit" and select a user (e.g., "root"). Choose "Password Expires on: 0". Choose "Edit value manually". Press ESC. Choose "Edit value manually" (again). Before bugfix, value is changed from "0" to NULL; after bugfix, value remains unchanged.

Execute "LANG=EN_US.ISO8859-1 bsdconfig foo" and see the error message is not cASE-rEVERSED (when LANG is set to EN_US.ISO8859-1, all text should be cASE-rEVERSED for i18n-testing). After bugfix, you should see "NOT FOUND" versus "not found" (indicating i18n-messages are working properly).

Execute "LANG=foo bsdconfig -h". Before bugfix, the output was sparse/lacking commands and other information. After bugfix, should look like "bsdconfig -h" (no LANG or LC_ALL set or set to NULL; each).

Similar test for "LANG=foo bsdconfig timezone -h"
Comment 1 Edwin Groothuis freebsd_committer 2012-06-21 22:50:31 UTC
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer 2012-06-21 22:50:38 UTC
Responsible Changed
From-To: freebsd-ports-bugs->eadler

eadler@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 3 Wesley Shields freebsd_committer 2012-06-22 02:41:31 UTC
Responsible Changed
From-To: eadler->wxs

Grab from eadler@.
Comment 4 dfilter freebsd_committer 2012-06-22 02:46:27 UTC
wxs         2012-06-22 01:46:16 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/bsdconfig   Makefile distinfo 
  Log:
  Update to 0.7.2.
  
  "When editing a user's password or account expiration property, choosing cancel
  or pressing ESC while editing the value manually would cause the value to be
  blanked rather than preserved. This has been fixed and pressing ESC (or
  choosing cancel) now preserves the value as expected.
  
  Executing "bsdconfig foo" when LANG is set to "EN_US.ISO8859-1" produces a
  non-i18n-compatible error message: "bsdconfig: foo: not found" (when it should
  produce: "bsdconfig: foo: NOT FOUND"). This has been fixed by adding the
  appropriate i18n messages and changing the code to use them.
  
  Executing "bsdconfig -h" when LANG is set to an unknown language (for which
  there are no bsdconfig localized language files), the output did not display
  appropriately. This has been fixed.
  
  Executing "bsdconfig timezone -h" (for example) when LANG is set to an unkown
  language had similar issues to the above."
  
  PR:             ports/169306
  Submitted by:   dteske@
  
  Revision  Changes    Path
  1.3       +2 -2      ports/sysutils/bsdconfig/Makefile
  1.3       +4 -4      ports/sysutils/bsdconfig/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Wesley Shields freebsd_committer 2012-06-22 02:49:38 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!