Bug 170441 - [PATCH] net/rinetd: fails to install due to file name collision
Summary: [PATCH] net/rinetd: fails to install due to file name collision
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Doug Barton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 09:10 UTC by Frank Wall
Modified: 2012-08-07 20:20 UTC (History)
0 users

See Also:


Attachments
file.diff (514 bytes, patch)
2012-08-07 09:10 UTC, Frank Wall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Wall 2012-08-07 09:10:01 UTC
Recently (r302141) the RC script was renamed from *.sh.in to *.in. This lead to a file name collision during the "make install" phase.

Fix: I've created a patch to address this issue by renaming/moving the ${WRKSRC}. I'm not sure if this is the appropiate fix, but it solves the issue for me.

Patch attached with submission follows:
How-To-Repeat: - try to install net/rinetd
- install will stop with this error message:

===>  Installing for rinetd-0.62_4
cannot create /work/a/ports/net/rinetd/work/rinetd: Is a directory
*** Error code 2

Stop in /a/ports/net/rinetd.
Comment 1 Edwin Groothuis freebsd_committer 2012-08-07 09:10:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jason Helfman freebsd_committer 2012-08-07 16:02:33 UTC
Responsible Changed
From-To: garga->dougb

you break, you fix
Comment 3 dfilter service freebsd_committer 2012-08-07 20:19:12 UTC
Author: dougb
Date: Tue Aug  7 19:19:02 2012
New Revision: 302255
URL: http://svn.freebsd.org/changeset/ports/302255

Log:
  Fix problem introduced in r302141. The directory for the  unpacked source
  files is unversioned, so it conflicts with the name of the rc.d script in
  WRKDIR after SUB_FILES is applied.
  
  This is the same method as suggested in the PR (and that I've used
  previously), just slightly different in the details.
  
  PR:		ports/170441
  Submitted by:	Frank Wall <fw@moov.de>
  Approved by:	maintainer

Modified:
  head/net/rinetd/Makefile

Modified: head/net/rinetd/Makefile
==============================================================================
--- head/net/rinetd/Makefile	Tue Aug  7 18:37:01 2012	(r302254)
+++ head/net/rinetd/Makefile	Tue Aug  7 19:19:02 2012	(r302255)
@@ -19,7 +19,7 @@ COMMENT=	A simple TCP port redirector
 
 OPTIONS_DEFINE=	DOCS
 
-WRKSRC=		${WRKDIR}/rinetd/
+WRKSRC=		${WRKDIR}/rinetd-${PORTVERSION}
 
 MAKE_JOBS_SAFE=	yes
 USE_DOS2UNIX=	yes
@@ -32,6 +32,9 @@ USE_RC_SUBR=	rinetd
 
 .include <bsd.port.pre.mk>
 
+post-extract:
+	@${MV} ${WRKDIR}/rinetd ${WRKSRC}
+
 post-patch:
 	@${REINPLACE_CMD} -E "s,(/etc/rinetd.conf),${PREFIX}\1," \
 		${WRKSRC}/rinetd.[8c]
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Doug Barton freebsd_committer 2012-08-07 20:20:14 UTC
State Changed
From-To: open->closed


Fixed in r302255. Thanks!