Bug 170997 - [patch] audio/gstreamer-plugins-flite: unresolvable links to libflite*
[patch] audio/gstreamer-plugins-flite: unresolvable links to libflite*
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: freebsd-multimedia
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-24 18:30 UTC by Alberto Villa
Modified: 2012-08-24 19:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.09 KB, patch)
2012-08-24 18:30 UTC, Alberto Villa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Villa freebsd_committer 2012-08-24 18:30:01 UTC
gstreamer-plugins-flite has a build dependency on flite assuming that it's linking to flite static library. Instead, libchk reports:

Unresolvable link(s) found in: /usr/local/lib/gstreamer-0.10/libgstflite.so
        libflite.so.1
        libflite_cmulex.so.1
        libflite_cmu_us_kal.so.1
        libflite_usenglish.so.1

Fix: The attached patch changes BUILD_DEPENDS to LIB_DEPENDS and bumps PORTREVISION for gstreamer-plugins-flite. It could be changed to make the plugin link to the static library, but I didn't want to dig into GStreamer configure nightmare, so this was my solution.

Patch attached with submission follows:
How-To-Repeat: # pkg install gstreamer-plugins-flite
$ ldd /usr/local/lib/gstreamer-0.10/libgstflite.so | grep flite
Comment 1 Edwin Groothuis freebsd_committer 2012-08-24 18:30:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-multimedia

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2012-08-24 19:13:40 UTC
Author: avilla
Date: Fri Aug 24 18:13:28 2012
New Revision: 303096
URL: http://svn.freebsd.org/changeset/ports/303096

Log:
  - Add dependency on flite shared library in gstreamer-plugins-flite to
    fix unresolvable links.
  - Bump PORTREVISION.
  
  PR:		170997
  Submitted by:	avilla (me)
  Approved by:	kwm (multimedia)

Modified:
  head/audio/gstreamer-plugins-flite/Makefile
  head/multimedia/gstreamer-plugins/Makefile.common

Modified: head/audio/gstreamer-plugins-flite/Makefile
==============================================================================
--- head/audio/gstreamer-plugins-flite/Makefile	Fri Aug 24 17:16:37 2012	(r303095)
+++ head/audio/gstreamer-plugins-flite/Makefile	Fri Aug 24 18:13:28 2012	(r303096)
@@ -5,7 +5,7 @@
 # $FreeBSD$
 #
 
-PORTREVISION=	0
+PORTREVISION=	1
 CATEGORIES=	audio
 
 COMMENT=	Gstreamer flite run-time speech synthesis engine plugin

Modified: head/multimedia/gstreamer-plugins/Makefile.common
==============================================================================
--- head/multimedia/gstreamer-plugins/Makefile.common	Fri Aug 24 17:16:37 2012	(r303095)
+++ head/multimedia/gstreamer-plugins/Makefile.common	Fri Aug 24 18:13:28 2012	(r303096)
@@ -285,10 +285,10 @@ gst_flac_PLIST_FILES=	${GST_LIB_DIR}/lib
 			${GST_LIB_DIR}/libgstflac.so
 
 # flite
-gst_flite_BUILD_DEPENDS+=	${LOCALBASE}/lib/libflite.a:${PORTSDIR}/audio/flite
-gst_flite_PLIST_FILES=		${GST_LIB_DIR}/libgstflite.la \
-				${GST_LIB_DIR}/libgstflite.so
-gst_flite_DIST=			bad
+gst_flite_LIB_DEPENDS+=	flite.1:${PORTSDIR}/audio/flite
+gst_flite_PLIST_FILES=	${GST_LIB_DIR}/libgstflite.la \
+			${GST_LIB_DIR}/libgstflite.so
+gst_flite_DIST=		bad
 
 # gconf
 gst_gconf_USE_GNOME+=	gnomeprefix gconf2
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Alberto Villa freebsd_committer 2012-08-24 19:15:35 UTC
State Changed
From-To: open->closed

Committed.