Bug 171158 - [patch] editors/vim -- remove limitation on unthreaded version of Tcl
Summary: [patch] editors/vim -- remove limitation on unthreaded version of Tcl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: David E. O'Brien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-29 11:20 UTC by Pietro Cerutti
Modified: 2012-09-12 16:50 UTC (History)
0 users

See Also:

Attachments
file.diff (257 bytes, patch)
2012-08-29 11:20 UTC, Pietro Cerutti 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti freebsd_committer freebsd_triage 2012-08-29 11:20:01 UTC 
The WITH_TCL option in editor/vim requires an unthreaded version of Tcl via the USE_TCL_NO_THREADS variable. I think this is not needed. I have successfully built vim against a threaded version of Tcl and run-tested some basic :tcldo stuff.

I kindly ask you to check whether this is really needed, and in case it's not, to approve my patch.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-29 11:20:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-09-12 16:40:37 UTC 
Author: obrien
Date: Wed Sep 12 15:40:26 2012
New Revision: 304151
URL: http://svn.freebsd.org/changeset/ports/304151

Log:
  Remove limitation on unthreaded version of Tcl.
  
  PR:		171158
  Submitted by:	gahr

Modified:
  head/editors/vim/Makefile

Modified: head/editors/vim/Makefile
==============================================================================
--- head/editors/vim/Makefile	Wed Sep 12 15:15:15 2012	(r304150)
+++ head/editors/vim/Makefile	Wed Sep 12 15:40:26 2012	(r304151)
@@ -88,8 +88,7 @@ MAKE_ARGS+=	CONF_OPT_RUBY="--enable-ruby
 .endif
 
 .if defined(WITH_TCL)
-USE_TCL=	82+
-USE_TCL_NO_THREADS=	yes
+USE_TCL=	85+
 .endif
 
 .if defined(WITH_LUA)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 David E. O'Brien freebsd_committer freebsd_triage 2012-09-12 16:40:59 UTC 
State Changed
From-To: open->closed

Committed as r304151.