Bug 171819 - [MAINTAINER] multimedia/gtk-youtube-viewer: Makefile changed, Port require always DATA, fixed missing
[MAINTAINER] multimedia/gtk-youtube-viewer: Makefile changed, Port require al...
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Raphael Kubo da Costa
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-20 19:40 UTC by nemysis
Modified: 2012-09-23 16:20 UTC (History)
1 user (show)

See Also:


Attachments
gtk-youtube-viewer-2.0.5.patch (1.84 KB, patch)
2012-09-20 19:40 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-09-20 19:40:04 UTC
Makefile changed:

Port require always DATA

-.if ${PORT_OPTIONS:MDATA}
 	@(cd ${WRKSRC} && ${COPYTREE_SHARE} "icons lib" ${DATADIR})
 	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.pl ${DATADIR}
 	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.glade ${DATADIR}
-.endif


Added missing directory

+	${MKDIR} ${PREFIX}/share/applications

Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.


Build log RedPorts

https://redports.org/buildarchive/20120920133509-46693/
Comment 1 Raphael Kubo da Costa freebsd_committer 2012-09-23 16:12:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rakuco

I'll take it.
Comment 2 Raphael Kubo da Costa freebsd_committer 2012-09-23 16:14:54 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter freebsd_committer 2012-09-23 16:15:17 UTC
Author: rakuco
Date: Sun Sep 23 15:14:54 2012
New Revision: 304746
URL: http://svn.freebsd.org/changeset/ports/304746

Log:
  - Remove the DATA option, as it is always required.
  - Create ${PREFIX}/share/applications, which is not part of the
    default mtree.
  - Update pkg-descr a little.
  
  PR:		ports/171819
  Submitted by:	nemysis <nemysis@gmx.ch> (maintainer)

Modified:
  head/multimedia/gtk-youtube-viewer/Makefile
  head/multimedia/gtk-youtube-viewer/pkg-descr

Modified: head/multimedia/gtk-youtube-viewer/Makefile
==============================================================================
--- head/multimedia/gtk-youtube-viewer/Makefile	Sun Sep 23 15:01:32 2012	(r304745)
+++ head/multimedia/gtk-youtube-viewer/Makefile	Sun Sep 23 15:14:54 2012	(r304746)
@@ -9,6 +9,7 @@ PORTNAME=	gtk-youtube-viewer
 PORTVERSION=	2.0.5
 CATEGORIES=	multimedia
 MASTER_SITES=	GOOGLE_CODE
+PROJECTHOST=	trizen
 
 MAINTAINER=	nemysis@gmx.ch
 COMMENT=	GTK Search and play YouTube videos streaming in MPlayer
@@ -22,15 +23,13 @@ RUN_DEPENDS=	p5-XML-Fast>=0:${PORTSDIR}/
 		p5-LWP-Protocol-https>=0:${PORTSDIR}/www/p5-LWP-Protocol-https \
 		mplayer:${PORTSDIR}/multimedia/mplayer
 
-OPTIONS_DEFINE=	DATA GCAP
+OPTIONS_DEFINE=	GCAP
 GCAP_DESC=	GCAP support
-OPTIONS_DEFAULT=	DATA
 
 WRKSRC=		${WRKDIR}/${PORTNAME}/src
 
 USE_PERL5_RUN=	yes
 NO_BUILD=	yes
-PROJECTHOST=	trizen
 
 PLIST_FILES=	bin/${PORTNAME} \
 		share/pixmaps/${PORTNAME}.png \
@@ -55,14 +54,13 @@ do-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/youtube-viewer ${DATADIR}
 
 # Data
-.if ${PORT_OPTIONS:MDATA}
 	@(cd ${WRKSRC} && ${COPYTREE_SHARE} "icons lib" ${DATADIR})
 	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.pl ${DATADIR}
 	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.glade ${DATADIR}
-.endif
 
 # Pixmaps and Desktop
 	${INSTALL_DATA} ${WRKSRC}/icons/${PORTNAME}.png ${PREFIX}/share/pixmaps/
+	${MKDIR} ${PREFIX}/share/applications
 	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.desktop ${PREFIX}/share/applications/
 
 .include <bsd.port.mk>

Modified: head/multimedia/gtk-youtube-viewer/pkg-descr
==============================================================================
--- head/multimedia/gtk-youtube-viewer/pkg-descr	Sun Sep 23 15:01:32 2012	(r304745)
+++ head/multimedia/gtk-youtube-viewer/pkg-descr	Sun Sep 23 15:14:54 2012	(r304746)
@@ -1,4 +1,4 @@
 GTK Youtube Viewer is created to be a flexible and reliable open-source
-Linux application which is dedicated to streaming Youtube Videos with MPlayer. 
+Linux application which is dedicated to streaming Youtube Videos with MPlayer.
 
 WWW:	https://code.google.com/p/trizen/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"