Bug 172473 - Fix for broken net/libtrace port
Summary: Fix for broken net/libtrace port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 05:10 UTC by Shane Alcock
Modified: 2013-02-18 05:30 UTC (History)
0 users

See Also:


Attachments
file.diff (7.25 KB, patch)
2012-10-08 05:10 UTC, Shane Alcock
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shane Alcock 2012-10-08 05:10:10 UTC
The attached patch should update the net/libtrace port to use the current libtrace release (3.0.15 compared with 3.0.6) and to build successfully on FreeBSD 9.0.

The patch also updates the port Makefile to add libpcap as a requirement, so this will now be installed if missing when attempting to build libtrace.

This is my first time working with FreeBSD ports, so feel free to get in touch if I've made a mistake or forgotten something.

Fix: Applying the attached patch should be sufficient.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-08 05:10:20 UTC
Maintainer of net/libtrace,

Please note that PR ports/172473 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172473

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-10-08 05:10:22 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Matt Peterson 2012-10-09 17:04:56 UTC
Approved
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2012-10-10 01:15:05 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2012-10-10 21:38:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 6 Jason Helfman freebsd_committer freebsd_triage 2012-10-10 23:08:37 UTC
Any ideas on how this can be fixed for 7.x?

https://redports.org/buildarchive/20121010205600-22969/

-jgh

-- 
Jason Helfman
FreeBSD Committer | http://people.freebsd.org/~jgh | The Power To Serve
Comment 7 Jason Helfman freebsd_committer freebsd_triage 2012-10-15 06:25:18 UTC
State Changed
From-To: open->feedback

awaiting feedback for 7.x failures
Comment 8 Jason Helfman freebsd_committer freebsd_triage 2012-11-19 19:44:46 UTC
Responsible Changed
From-To: jgh->freebsd-ports-bugs

back to the heap
Comment 9 Martin Wilke freebsd_committer freebsd_triage 2013-02-18 05:25:45 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 10 dfilter service freebsd_committer freebsd_triage 2013-02-18 05:25:53 UTC
Author: miwi
Date: Mon Feb 18 05:25:41 2013
New Revision: 312478
URL: http://svnweb.freebsd.org/changeset/ports/312478

Log:
  - Update to 3.0.15
  
  PR:		172473
  Submitted by:	Shane Alcock <salcock@waikato.ac.nz>
  Approved by:	maintainer

Modified:
  head/net/libtrace/Makefile   (contents, props changed)
  head/net/libtrace/distinfo   (contents, props changed)
  head/net/libtrace/pkg-descr   (contents, props changed)
  head/net/libtrace/pkg-plist   (contents, props changed)

Modified: head/net/libtrace/Makefile
==============================================================================
--- head/net/libtrace/Makefile	Mon Feb 18 04:45:53 2013	(r312477)
+++ head/net/libtrace/Makefile	Mon Feb 18 05:25:41 2013	(r312478)
@@ -1,29 +1,26 @@
-# New ports collection makefile for:	libtrace
-# Date created:				Mon Oct  8 20:32:57 PDT 2007
-# Whom:					Matt Peterson <matt@peterson.org>
-#
+# Created by: Matt Peterson <matt@peterson.org>
 # $FreeBSD$
-#
 
 PORTNAME=	libtrace
-PORTVERSION=	3.0.6
+PORTVERSION=	3.0.15
 CATEGORIES=	net
-MASTER_SITES=	http://research.wand.net.nz/software/libtrace/ \
-		http://matt.peterson.org/FreeBSD/ports/
+MASTER_SITES=	http://research.wand.net.nz/software/libtrace/
 
 MAINTAINER=	matt@peterson.org
-COMMENT=	C library for network device, raw & compressed network flows
+COMMENT=	C library for network packet capture and processing
+
+LIB_DEPENDS=	pcap:${PORTSDIR}/net/libpcap
 
 CONFIGURE_ARGS=	--with-libpcap=${LOCALBASE}
 
-USE_BZIP2=	yes
 GNU_CONFIGURE=	yes
 USE_LDCONFIG=	yes
 USE_GMAKE=	yes
 
-MAN1=		traceanon.1 traceconvert.1 tracefilter.1 tracemerge.1  tracepktdump.1 \
-		tracereport.1 tracertstats.1 tracesplit.1 tracesplit_dir.1 tracestats.1 \
-		tracesummary.1
+MAN1=	traceanon.1 traceconvert.1 tracefilter.1 tracemerge.1 \
+	tracereport.1 tracertstats.1 tracesplit.1 tracepktdump.1 \
+	tracesplit_dir.1 tracestats.1 tracesummary.1 tracereplay.1 \
+	tracediff.1 traceends.1 tracetop.1 tracetopends.1
 
 LDFLAGS+=	-L${LOCALBASE}/lib
 
@@ -31,10 +28,4 @@ post-patch:
 	@${REINPLACE_CMD} -e 's|echo aout|echo elf|g' \
 	${WRKSRC}/configure
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} >= 900000
-BROKEN=		does not build
-.endif
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/net/libtrace/distinfo
==============================================================================
--- head/net/libtrace/distinfo	Mon Feb 18 04:45:53 2013	(r312477)
+++ head/net/libtrace/distinfo	Mon Feb 18 05:25:41 2013	(r312478)
@@ -1,2 +1,2 @@
-SHA256 (libtrace-3.0.6.tar.bz2) = a87e2ca91f19838c9876b582ad1cf275d6f41cade0a847757b8e844f39cb6afa
-SIZE (libtrace-3.0.6.tar.bz2) = 457661
+SHA256 (libtrace-3.0.15.tar.gz) = 720a80e54205cee1c038a4e272c76606a3c6146103067210a60a77fa8932cb1c
+SIZE (libtrace-3.0.15.tar.gz) = 1436159

Modified: head/net/libtrace/pkg-descr
==============================================================================
--- head/net/libtrace/pkg-descr	Mon Feb 18 04:45:53 2013	(r312477)
+++ head/net/libtrace/pkg-descr	Mon Feb 18 05:25:41 2013	(r312478)
@@ -1,5 +1,11 @@
-libtrace is a library for trace processing. It supports multiple input methods,
-including device capture, raw and gz-compressed trace, and sockets; and mulitple
-input formats, including pcap and DAG.
+libtrace is a library for capturing and processing network traffic, similar to
+libpcap. Libtrace supports multiple trace formats for both input and output
+including live device capture, DAG hardware capture and off-line trace files
+(both compressed and uncompressed).
+
+More information about libtrace can be found on the libtrace webpage.
 
 WWW: http://research.wand.net.nz/software/libtrace.php
+
+Original port created by Matt Peterson <matt at peterson.org>
+Updated for FreeBSD 9.0 by Shane Alcock <salcock at waikato.ac.nz>

Modified: head/net/libtrace/pkg-plist
==============================================================================
--- head/net/libtrace/pkg-plist	Mon Feb 18 04:45:53 2013	(r312477)
+++ head/net/libtrace/pkg-plist	Mon Feb 18 05:25:41 2013	(r312478)
@@ -1,26 +1,35 @@
 bin/traceanon
 bin/traceconvert
+bin/tracediff
+bin/traceends
 bin/tracefilter
 bin/tracemerge
 bin/tracepktdump
+bin/tracereplay
 bin/tracereport
 bin/tracertstats
 bin/tracesplit
 bin/tracesplit_dir
 bin/tracestats
 bin/tracesummary
+bin/tracetop
+bin/tracetopends
 include/dagformat.h
 include/daglegacy.h
 include/erftypes.h
 include/libpacketdump.h
 include/libtrace.h
-include/libtraceio.h
 include/lt_inttypes.h
 include/rt_protocol.h
+include/wandio.h
 lib/libpacketdump.a
 lib/libpacketdump.la
 lib/libpacketdump.so
 lib/libpacketdump.so.3
+lib/libpacketdump/eth_0.a
+lib/libpacketdump/eth_0.la
+lib/libpacketdump/eth_0.so
+lib/libpacketdump/eth_0.so.0
 lib/libpacketdump/eth_2048.a
 lib/libpacketdump/eth_2048.la
 lib/libpacketdump/eth_2048.so
@@ -33,7 +42,10 @@ lib/libpacketdump/eth_33024.a
 lib/libpacketdump/eth_33024.la
 lib/libpacketdump/eth_33024.so
 lib/libpacketdump/eth_33024.so.0
-lib/libpacketdump/eth_34525.protocol
+lib/libpacketdump/eth_34525.a
+lib/libpacketdump/eth_34525.la
+lib/libpacketdump/eth_34525.so
+lib/libpacketdump/eth_34525.so.0
 lib/libpacketdump/eth_34887.a
 lib/libpacketdump/eth_34887.la
 lib/libpacketdump/eth_34887.so
@@ -46,6 +58,10 @@ lib/libpacketdump/eth_34958.a
 lib/libpacketdump/eth_34958.la
 lib/libpacketdump/eth_34958.so
 lib/libpacketdump/eth_34958.so.0
+lib/libpacketdump/ip_0.a
+lib/libpacketdump/ip_0.la
+lib/libpacketdump/ip_0.so
+lib/libpacketdump/ip_0.so.0
 lib/libpacketdump/ip_1.a
 lib/libpacketdump/ip_1.la
 lib/libpacketdump/ip_1.so
@@ -62,7 +78,15 @@ lib/libpacketdump/ip_33.a
 lib/libpacketdump/ip_33.la
 lib/libpacketdump/ip_33.so
 lib/libpacketdump/ip_33.so.0
-lib/libpacketdump/ip_41.protocol
+lib/libpacketdump/ip_41.so
+lib/libpacketdump/ip_43.a
+lib/libpacketdump/ip_43.la
+lib/libpacketdump/ip_43.so
+lib/libpacketdump/ip_43.so.0
+lib/libpacketdump/ip_44.a
+lib/libpacketdump/ip_44.la
+lib/libpacketdump/ip_44.so
+lib/libpacketdump/ip_44.so.0
 lib/libpacketdump/ip_47.a
 lib/libpacketdump/ip_47.la
 lib/libpacketdump/ip_47.so
@@ -72,10 +96,22 @@ lib/libpacketdump/ip_6.a
 lib/libpacketdump/ip_6.la
 lib/libpacketdump/ip_6.so
 lib/libpacketdump/ip_6.so.0
+lib/libpacketdump/ip_60.a
+lib/libpacketdump/ip_60.la
+lib/libpacketdump/ip_60.so
+lib/libpacketdump/ip_60.so.0
+lib/libpacketdump/ip_89.a
+lib/libpacketdump/ip_89.la
+lib/libpacketdump/ip_89.so
+lib/libpacketdump/ip_89.so.0
 lib/libpacketdump/link_0.a
 lib/libpacketdump/link_0.la
 lib/libpacketdump/link_0.so
 lib/libpacketdump/link_0.so.0
+lib/libpacketdump/link_1.a
+lib/libpacketdump/link_1.la
+lib/libpacketdump/link_1.so
+lib/libpacketdump/link_1.so.0
 lib/libpacketdump/link_10.a
 lib/libpacketdump/link_10.la
 lib/libpacketdump/link_10.so
@@ -103,9 +139,53 @@ lib/libpacketdump/link_6.a
 lib/libpacketdump/link_6.la
 lib/libpacketdump/link_6.so
 lib/libpacketdump/link_6.so.0
+lib/libpacketdump/link_9.a
+lib/libpacketdump/link_9.la
+lib/libpacketdump/link_9.so
+lib/libpacketdump/link_9.so.0
+lib/libpacketdump/ospf2_1.a
+lib/libpacketdump/ospf2_1.la
+lib/libpacketdump/ospf2_1.so
+lib/libpacketdump/ospf2_1.so.0
+lib/libpacketdump/ospf2_1000.a
+lib/libpacketdump/ospf2_1000.la
+lib/libpacketdump/ospf2_1000.so
+lib/libpacketdump/ospf2_1000.so.0
+lib/libpacketdump/ospf2_1001.a
+lib/libpacketdump/ospf2_1001.la
+lib/libpacketdump/ospf2_1001.so
+lib/libpacketdump/ospf2_1001.so.0
+lib/libpacketdump/ospf2_1002.a
+lib/libpacketdump/ospf2_1002.la
+lib/libpacketdump/ospf2_1002.so
+lib/libpacketdump/ospf2_1002.so.0
+lib/libpacketdump/ospf2_1003.a
+lib/libpacketdump/ospf2_1003.la
+lib/libpacketdump/ospf2_1003.so
+lib/libpacketdump/ospf2_1003.so.0
+lib/libpacketdump/ospf2_1004.a
+lib/libpacketdump/ospf2_1004.la
+lib/libpacketdump/ospf2_1004.so
+lib/libpacketdump/ospf2_1004.so.0
+lib/libpacketdump/ospf2_1005.a
+lib/libpacketdump/ospf2_1005.la
+lib/libpacketdump/ospf2_1005.so
+lib/libpacketdump/ospf2_1005.so.0
+lib/libpacketdump/ospf2_4.a
+lib/libpacketdump/ospf2_4.la
+lib/libpacketdump/ospf2_4.so
+lib/libpacketdump/ospf2_4.so.0
+lib/libpacketdump/ospf2_5.a
+lib/libpacketdump/ospf2_5.la
+lib/libpacketdump/ospf2_5.so
+lib/libpacketdump/ospf2_5.so.0
 lib/libpacketdump/ppp_33.so
 lib/libtrace.a
 lib/libtrace.la
 lib/libtrace.so
 lib/libtrace.so.3
-@dirrmtry lib/libpacketdump
+lib/libwandio.a
+lib/libwandio.la
+lib/libwandio.so
+lib/libwandio.so.1
+@dirrm lib/libpacketdump
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"