Bug 172547 - bsd.destdir.mk fails when DESTDIR is set
Summary: bsd.destdir.mk fails when DESTDIR is set
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-09 23:30 UTC by Rob
Modified: 2014-09-08 20:45 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob 2012-10-09 23:30:24 UTC 
When bsd.destdir.mk iterates over $_DESTDIR_MOUNT_LIST it runs:

# realpath $_destdir/__temp__

Due to changes in realpath (prior to June 2012) this causes a non-zero exit.  This then causes the make to fail.

Fix: 

Change /usr/ports/Mk/bsd.destdir.mk

_full_dest_path=`${REALPATH} $${_destdir}/$${_dest_path}`; \

to:

_full_dest_path=`${REALPATH} -q $${_destdir}/$${_dest_path} || :`; \


This may not be the proper fix, but it works around the issue.
How-To-Repeat: On a freshly built installation, attempt to perform a 

# make config DESTDIR=/usr/local/jails/imap1
===>  Creating some important subdirectories
realpath: /usr/local/jails/imap1/___temp___: No such file or directory
*** [do-chroot] Error code 1
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2013-02-08 02:55:33 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

portmgr pr.
Comment 2 andrew 2013-09-30 00:00:22 UTC 
Same in FreeBSD 9.1
realpath: /usr/jails/basejail/___temp___: No such file or directory

-- 
Best Regards,
Andrew Azarov
Azar-A Kft.
Hungary, 1158 Budapest, Petrence ú. 66.
Registration ID: 01-09-873403
Tel.:+36 1 6076556
Comment 3 Mark Linimon 2013-11-25 00:15:40 UTC 
----- Forwarded message from Lists <lists@somerandom.net> -----

Date: Sun, 24 Nov 2013 09:17:29 +0000
From: Lists <lists@somerandom.net>
To: freebsd-ports@freebsd.org
Subject: ports/172547: bsd.destdir.mk fails when DESTDIR is set
X-Mailer: Apple Mail (2.1822)

Hi,

Is there any change someone could look at ports/172547?

Without overriding REALPATH Iâm unable to install ports into an alternative root path.

http://www.freebsd.org/cgi/query-pr.cgi?pr=172547

thanks

Rob
_______________________________________________
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"


----- End forwarded message -----
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2014-06-02 02:49:38 UTC 
Infrastructure PR.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-09-08 20:44:48 UTC 
A commit references this bug:

Author: bdrewery
Date: Mon Sep  8 20:44:21 UTC 2014
New revision: 367700
URL: http://svnweb.freebsd.org/changeset/ports/367700

Log:
  - Fix DESTDIR support.
    It has been broken since r176977 in head in 2008.

  PR:		172547
  Submitted by:	Rob <pr@somerandom.net>
  With hat:	portmgr

Changes:
  head/Mk/bsd.destdir.mk
Comment 6 Bryan Drewery freebsd_committer freebsd_triage 2014-09-08 20:45:02 UTC 
Fixed