Bug 17281 - sigrot broken -here's the patch
Summary: sigrot broken -here's the patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-03-09 16:20 UTC by muk
Modified: 2000-04-02 02:19 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description muk 2000-03-09 16:20:01 UTC
	/usr/ports/mail/sigrot will compile, but will segfault if run with no arguments.

Fix: 

apply the following patch to sigrot.c:
	170c170
	<   else
	---
	>   else {
	172c172,173
	<   fclose(inFile);
	---
	>     fclose(inFile);
	>   }
How-To-Repeat: 
	make sigrot, run sigrot -w testfile, then run sigrot. It will segfault with no arguments. the expected behavior is to copy an entry from the sigrot_archive file into ~/.signature
Comment 1 Will Andrews 2000-03-09 17:35:56 UTC
On Thu, Mar 09, 2000 at 11:19:13AM -0500, muk@bender.cl.msu.edu wrote:
> 	apply the following patch to sigrot.c:
> 	170c170
> 	<   else
> 	---
> 	>   else {
> 	172c172,173
> 	<   fclose(inFile);
> 	---
> 	>     fclose(inFile);
> 	>   }

I believe the ports standard is diff -u.

-- 
Will Andrews <andrews@technologist.com>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ 
G++>+++ e->++++ h! r-->+++ y?
Comment 2 Michael Haro freebsd_committer freebsd_triage 2000-04-02 02:19:19 UTC
State Changed
From-To: open->closed

A patch has been added to this port. 
Thanks.