Bug 173882 - [PATCH] games/xsc: Changed Comment, added Deskop entries, take maintainership
Summary: [PATCH] games/xsc: Changed Comment, added Deskop entries, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-23 20:50 UTC by nemysis
Modified: 2013-07-10 12:00 UTC (History)
0 users

See Also:


Attachments
xsc-1.5_3.patch (1.62 KB, patch)
2012-11-23 20:50 UTC, nemysis
no flags Details | Diff
xsc.diff (1.76 KB, patch)
2013-02-23 17:00 UTC, nemysis
no flags Details | Diff
xsc.diff (1.42 KB, patch)
2013-07-07 22:36 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2012-11-23 20:50:00 UTC
- Take maintainership

Makefile changed:
+MASTER_SITES=
+DISTFILES=
+COMMENT=	Vector graphics space shoot'em up game
+DESKTOP_ENTRIES=
+post-install:

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
looks fine.

port test: clean

Can't give build log, because RedPorts not works at the time.
Comment 1 nemysis 2013-02-23 17:00:36 UTC
Changed

DESKTOP_ENTRIES="Xce" "${COMMENT}" \
                "${PREFIX}/share/pixmaps/${PORTNAME}.png" \
                "${PORTNAME}" "Game;ArcadeGame;" false
Comment 2 Danilo Egêa Gondolfo 2013-07-07 20:33:40 UTC
This PR can be closed.
Comment 3 nemysis 2013-07-07 22:36:10 UTC
- Trim master sites
- Add Icons
- Remove leading article from COMMENT
- Add Desktop entry file
- Trim PLIST_FILES


This PR is from 23 Nov 2012 and ports/177672 is from Sat, 6 Apr 2013.

Why i don't get maintainership?

Best regards,
nemysis
Comment 4 Danilo Egêa Gondolfo 2013-07-07 23:08:01 UTC
When I opened the PR, I forgot to see if there was one for this port, I'm
sorry. If you want, you can get maintainership, no problem.


On Sun, Jul 7, 2013 at 6:36 PM, nemysis <nemysis@gmx.ch> wrote:

> - Trim master sites
> - Add Icons
> - Remove leading article from COMMENT
> - Add Desktop entry file
> - Trim PLIST_FILES
>
>
> This PR is from 23 Nov 2012 and ports/177672 is from Sat, 6 Apr 2013.
>
> Why i don't get maintainership?
>
> Best regards,
> nemysis
Comment 5 nemysis 2013-07-07 23:20:26 UTC
I have upload long time ago icon for games/xsc to my SF Site.

Thanks i wish maintainership for this Port.

Best regards,
nemysis
Comment 6 Bryan Drewery freebsd_committer freebsd_triage 2013-07-08 15:28:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

I'll take it.
Comment 7 Bryan Drewery freebsd_committer freebsd_triage 2013-07-10 11:53:43 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 8 dfilter service freebsd_committer freebsd_triage 2013-07-10 11:53:50 UTC
Author: bdrewery
Date: Wed Jul 10 10:53:37 2013
New Revision: 322638
URL: http://svnweb.freebsd.org/changeset/ports/322638

Log:
  - Pass maintainership to submitter
  - Add desktop entries
  
  PR:		ports/173882
  Submitted by:	nemysis <nemysis@gmx.ch>
  Approved by:	Danilo Egea <danilogondolfo@gmail.com> (maintainer via email)

Modified:
  head/games/xsc/Makefile
  head/games/xsc/distinfo

Modified: head/games/xsc/Makefile
==============================================================================
--- head/games/xsc/Makefile	Wed Jul 10 10:33:08 2013	(r322637)
+++ head/games/xsc/Makefile	Wed Jul 10 10:53:37 2013	(r322638)
@@ -3,14 +3,27 @@
 
 PORTNAME=	xsc
 PORTVERSION=	1.6
+PORTREVISION=	1
 CATEGORIES=	games
-MASTER_SITES=	http://www.panix.com/~mbh/xsc/
+MASTER_SITES=	http://www.panix.com/~mbh/xsc/ \
+		SF/nemysisfreebsdp/:icons
+DISTFILES=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
+		${PORTNAME}.png:icons
+EXTRACT_ONLY=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX}
 
 MAINTAINER=	danilogondolfo@gmail.com
-COMMENT=	A vector graphics space shoot'em up game
+COMMENT=	Vector graphics space shoot'em up game
 
 USE_XORG=	x11
 GNU_CONFIGURE=	yes
-PLIST_FILES=	bin/xsc
+
+PLIST_FILES=	bin/${PORTNAME} \
+		share/pixmaps/${PORTNAME}.png
+
+DESKTOP_ENTRIES="Xce" "${COMMENT}" ${PORTNAME} \
+		"${PORTNAME}" "Game;ArcadeGame;" false
+
+post-install:
+	${INSTALL_DATA} ${_DISTDIR}/${PORTNAME}.png ${PREFIX}/share/pixmaps
 
 .include <bsd.port.mk>

Modified: head/games/xsc/distinfo
==============================================================================
--- head/games/xsc/distinfo	Wed Jul 10 10:33:08 2013	(r322637)
+++ head/games/xsc/distinfo	Wed Jul 10 10:53:37 2013	(r322638)
@@ -1,2 +1,4 @@
 SHA256 (xsc-1.6.tar.gz) = f271300c10423150562a290ed2a67910db804c7f11fbfd3e3f67016c039af8fa
 SIZE (xsc-1.6.tar.gz) = 140106
+SHA256 (xsc.png) = 4ae93202eb1df542fa559a3d46f7f5e687e8816efad56cc6b32111a17cb26d2e
+SIZE (xsc.png) = 381
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 9 Bryan Drewery freebsd_committer freebsd_triage 2013-07-10 11:54:13 UTC
I've transferred it to nemysis. Sorry for the mixup. My fault.

On 7/7/2013 5:08 PM, Danilo Egêa Gondolfo wrote:
> When I opened the PR, I forgot to see if there was one for this port,
> I'm sorry. If you want, you can get maintainership, no problem.
> 
> 
> On Sun, Jul 7, 2013 at 6:36 PM, nemysis <nemysis@gmx.ch
> <mailto:nemysis@gmx.ch>> wrote:
> 
>     - Trim master sites
>     - Add Icons
>     - Remove leading article from COMMENT
>     - Add Desktop entry file
>     - Trim PLIST_FILES
> 
> 
>     This PR is from 23 Nov 2012 and ports/177672 is from Sat, 6 Apr 2013.
> 
>     Why i don't get maintainership?
> 
>     Best regards,
>     nemysis
> 
> 



-- 
Regards,
Bryan Drewery