Bug 174051 - [build] [patch] Make tcsh compilation optional at top-level make
Summary: [build] [patch] Make tcsh compilation optional at top-level make
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: unspecified
Hardware: Any Any
: Normal Affects Some People
Assignee: Ngie Cooper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-02 12:20 UTC by Ngie Cooper
Modified: 2017-10-04 16:36 UTC (History)
1 user (show)

See Also:
ngie: mfc-stable9-
ngie: mfc-stable10+
ngie: mfc-stable11+


Attachments
file.diff (385 bytes, patch)
2012-12-02 12:20 UTC, Ngie Cooper
no flags Details | Diff
Makefile.inc1: Respect WITHOUT_TCSH (4.35 KB, patch)
2017-08-27 11:17 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ngie Cooper freebsd_committer 2012-12-02 12:20:01 UTC
The attached patch makes tcsh compilation rightfully optional in Makefile.inc1 because it currently is always built regardless of the MK_TCSH setting.

Fix: Patch attached with submission follows:
How-To-Repeat: cd /usr/src; make -DWITHOUT_TCSH buildworld
Comment 1 Fabian Keil 2017-08-27 11:17:47 UTC
Created attachment 185812 [details]
Makefile.inc1: Respect WITHOUT_TCSH

I've been using the attached patch in ElectroBSD since 2015.

The first hunk looks the same (except for the line numbers) but
there's a second one which probably wasn't needed in 2013 yet.
Comment 2 commit-hook freebsd_committer 2017-08-27 16:16:37 UTC
A commit references this bug:

Author: ngie
Date: Sun Aug 27 16:15:38 UTC 2017
New revision: 322951
URL: https://svnweb.freebsd.org/changeset/base/322951

Log:
  Respect MK_TCSH with build-tools and native-xtools

  This helps reduce the WORLDTMP footprint slightly.

  Based on a patch I submitted 5 years ago to GNATS.

  PR:		174051
  MFC after:	2 weeks
  Relnotes:	yes (anyone who cross-builds with MK_TCSH=yes will run into
  		     build failures if the host doesn't have tcsh(1))
  Reminded by:	Fabian Keil <fk@fabiankeil.de>

Changes:
  head/Makefile.inc1
Comment 3 commit-hook freebsd_committer 2017-09-30 20:07:41 UTC
A commit references this bug:

Author: ngie
Date: Sat Sep 30 20:06:44 UTC 2017
New revision: 324133
URL: https://svnweb.freebsd.org/changeset/base/324133

Log:
  MFC r322951:

  Respect MK_TCSH with build-tools and native-xtools

  This helps reduce the WORLDTMP footprint slightly.

  Based on a patch I submitted 5 years ago to GNATS.

  PR:		174051
  Relnotes:	yes (anyone who cross-builds with MK_TCSH=yes will run into
  		     build failures if the host doesn't have tcsh(1))
  Reminded by:	Fabian Keil <fk@fabiankeil.de>

Changes:
_U  stable/11/
  stable/11/Makefile.inc1
Comment 4 commit-hook freebsd_committer 2017-09-30 20:45:11 UTC
A commit references this bug:

Author: ngie
Date: Sat Sep 30 20:44:26 UTC 2017
New revision: 324139
URL: https://svnweb.freebsd.org/changeset/base/324139

Log:
  MFC r322951:

  Respect MK_TCSH with build-tools and native-xtools

  This helps reduce the WORLDTMP footprint slightly.

  Based on a patch I submitted 5 years ago to GNATS.

  PR:		174051
  Relnotes:	yes (anyone who cross-builds with MK_TCSH=yes will run into
  		     build failures if the host doesn't have tcsh(1))
  Reminded by:	Fabian Keil <fk@fabiankeil.de>

Changes:
_U  stable/10/
  stable/10/bin/Makefile
  stable/10/sbin/Makefile
  stable/10/usr.bin/Makefile
  stable/10/usr.sbin/Makefile
Comment 5 commit-hook freebsd_committer 2017-10-04 16:36:07 UTC
A commit references this bug:

Author: ngie
Date: Wed Oct  4 16:35:58 UTC 2017
New revision: 324284
URL: https://svnweb.freebsd.org/changeset/base/324284

Log:
  MFC r322951:

  Respect MK_TCSH with build-tools and native-xtools

  This helps reduce the WORLDTMP footprint slightly.

  Based on a patch I submitted 5 years ago to GNATS.

  PR:		174051
  Relnotes:	yes (anyone who cross-builds with MK_TCSH=yes will run into
  		     build failures if the host doesn't have tcsh(1))
  Reminded by:	Fabian Keil <fk@fabiankeil.de>

Changes:
_U  stable/10/
  stable/10/Makefile.inc1