- remove bogus setuptools dependency - trim Makefile header - move LICENSE and *_DEPENDS into proper block (portlint warning) - remove shlib version in LIB_DEPENDS (portlint warning) - eliminate using PYTHON_SITELIBDIR - convert to optionsng - limit python version to 2.x only since noc (and the most of it's dependencies) not [fully] supports 3.x - remove trailin whitespace from pkg-descr - do not bump PORTREVISION because the port is marked BROKEN (next 0.7.5 release adding django 1.4 support, so hopefully it will be working again soon) As for setuptools dependency - it's only usage is in erroneous setup.py's comment. It also mentioned in installation guide, but only in context of installing it's dependencies (that is already handled by our ports tree). As you may see in setup.py, it's using distutils for installing. buildlog: http://people.freebsd.org/~rm/noc-0.6.4_1.log Fix: Patch attached with submission follows:
Maintainer of net-mgmt/noc, Please note that PR ports/174145 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174145 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I changed django dependency line to test the build w/o setuptools and forgot to turn it back after successful testing. Here is updated patch, that differs from original one only in that django version thing. -- Regards, Ruslan Tinderboxing kills... the drives.
State Changed From-To: feedback->closed Committed, thank you!