Bug 176238 - [ath] [patch] Correct buffer size calculation and simplify calling if_ath_alq_post()
Summary: [ath] [patch] Correct buffer size calculation and simplify calling if_ath_alq...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: wireless (show other bugs)
Version: 1.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-wireless (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-18 13:30 UTC by Christoph Mallon
Modified: 2019-01-20 03:40 UTC (History)
2 users (show)

See Also:

Attachments
0001-ath-Correct-sizeof-calculation-in-if_ath_alq_post_in.patch (852 bytes, patch)
2013-02-18 13:30 UTC, Christoph Mallon 		no flags Details | Diff
0002-ath-Simplify-usage-of-if_ath_alq_post-by-changing-th.patch (5.83 KB, patch)
2013-02-18 13:30 UTC, Christoph Mallon 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Mallon 2013-02-18 13:30:01 UTC 
These patches address two points:
- Correct buffer size calculation when calling if_ath_alq_post_in() in if_ath_alq_post_intr()
- Avoid explicit casts for calling if_ath_alq_post() by making buf a const void*

Fix: Please apply these patches.

dummy file, because GNATS damages every other patch
--- dummy1 ends here ---
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2013-02-18 17:17:18 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-wireless

Over to maintainer(s).
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-02-18 18:39:28 UTC 
Author: adrian
Date: Mon Feb 18 18:39:15 2013
New Revision: 246945
URL: http://svnweb.freebsd.org/changeset/base/246945

Log:
  Fix an incorrect sizeof()
  
  PR:		kern/176238
  Submitted by:	Christoph Mallon <christoph.mallon@gmx.de>

Modified:
  head/sys/dev/ath/if_ath_alq.h

Modified: head/sys/dev/ath/if_ath_alq.h
==============================================================================
--- head/sys/dev/ath/if_ath_alq.h	Mon Feb 18 17:55:27 2013	(r246944)
+++ head/sys/dev/ath/if_ath_alq.h	Mon Feb 18 18:39:15 2013	(r246945)
@@ -168,7 +168,7 @@ if_ath_alq_post_intr(struct if_ath_alq *
 		intr.intr_state[i] = htobe32(state[i]);
 	intr.intr_syncstate = htobe32(sync_state);
 
-	if_ath_alq_post(alq, ATH_ALQ_INTR_STATUS, sizeof(&intr),
+	if_ath_alq_post(alq, ATH_ALQ_INTR_STATUS, sizeof(intr),
 	    (const char *) &intr);
 }
 
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2018-05-28 19:45:41 UTC 
batch change:

For bugs that match the following
-  Status Is In progress 
AND
- Untouched since 2018-01-01.
AND
- Affects Base System OR Documentation

DO:

Reset to open status.


Note:
I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.
Comment 4 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-20 03:40:38 UTC 
There was a commit referencing this bug, but it's still not closed and has been inactive for some time. Closing as fixed. Please re-open it if the issue hasn't been completely resolved.