Bug 176744 - [geom] [patch] BIO_FLUSH not recorded by devstats
Summary: [geom] [patch] BIO_FLUSH not recorded by devstats
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 10.0-CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexander Motin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-08 08:30 UTC by Matt Burke
Modified: 2014-07-16 03:01 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (799 bytes, patch)
2013-03-08 08:30 UTC, Matt Burke 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Burke 2013-03-08 08:30:00 UTC 
BIO_FLUSH operations are not recorded by devstats

Fix: Apply attached patch

Patch attached with submission follows:
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2013-03-10 04:43:46 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-geom

Over to maintainer(s).
Comment 2 Christian Brueffer freebsd_committer freebsd_triage 2014-02-05 17:11:49 UTC 
State Changed
From-To: open->feedback

Hi Matt, I debated this change with mav@ and we were wondering what your specific 
use for this change is. 

While an adapted version (https://people.freebsd.org/~brueffer/geom_devstat.diff) 
of this patch works, the upstream userland tools have no special handling for BIO_FLUSH 
events.  They end up in the _OTHER categories of libdevstat(3), which e.g. gstat does not 
show at all. 

Could you elaborate?
Comment 3 Christian Brueffer freebsd_committer freebsd_triage 2014-05-18 13:41:19 UTC 
State Changed
From-To: feedback->patched

mav@ committed the necessary changes to HEAD in r266319.
Comment 4 Brooks Davis freebsd_committer freebsd_triage 2014-07-15 18:52:50 UTC 
Assign to mav@ so he can decide to MFC or not as appropriate.
Comment 5 Alexander Motin freebsd_committer freebsd_triage 2014-07-16 03:01:10 UTC 
It was merged to stable/10 on 2014-05-24.