Bug 177518 - [patch] editors/emacs builds with gtk3 even if gtk2 selected
Summary: [patch] editors/emacs builds with gtk3 even if gtk2 selected
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-31 11:20 UTC by rsmith
Modified: 2013-04-02 04:40 UTC (History)
0 users

See Also:


Attachments
file.diff (337 bytes, patch)
2013-03-31 11:20 UTC, rsmith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2013-03-31 11:20:00 UTC
    When building emacs-24.3,3, I realized that it used gtk3, even
	though gtk2 was selected in options. It turns out that this is a
	bug in the port Makefile, which tries to select gtk1 instead of gkt2!

Fix: Apply the following small fix to the port Makefile
How-To-Repeat: 	Build the port with both gtk2 and gtk3 installed.
Comment 1 Edwin Groothuis freebsd_committer 2013-03-31 11:20:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ashish

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Ashish SHUKLA freebsd_committer 2013-03-31 14:41:36 UTC
Hi,

Thanks for the noticing. I didn't test all toolkits, and it seems like Emacs
team decided to change toolkit name for GTK 2.x.

I'll test it, and contact portmgr to get this fix committed.

Thanks
-- 
Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
Sent from my Emacs
Comment 3 dfilter service freebsd_committer 2013-04-02 04:36:39 UTC
Author: ashish
Date: Tue Apr  2 03:36:31 2013
New Revision: 315658
URL: http://svnweb.freebsd.org/changeset/ports/315658

Log:
  - Fix dependency on GTK2 for GTK2 option
  
  PR:		ports/177518
  Submitted by:	Roland Smith <rsmith at xs4all.nl>
  Approved by:	portmgr

Modified:
  head/editors/emacs/Makefile

Modified: head/editors/emacs/Makefile
==============================================================================
--- head/editors/emacs/Makefile	Tue Apr  2 01:48:51 2013	(r315657)
+++ head/editors/emacs/Makefile	Tue Apr  2 03:36:31 2013	(r315658)
@@ -102,7 +102,7 @@ CONFIGURE_ARGS+=	--without-rsvg
 
 .if ${PORT_OPTIONS:MGTK2}
 USE_GNOME+=	gtk20
-CONFIGURE_ARGS+=	--with-x-toolkit=gtk
+CONFIGURE_ARGS+=	--with-x-toolkit=gtk2
 .elif ${PORT_OPTIONS:MGTK3}
 USE_GNOME+=	gtk30
 CONFIGURE_ARGS+=	--with-x-toolkit=gtk3
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Ashish SHUKLA freebsd_committer 2013-04-02 04:37:04 UTC
State Changed
From-To: open->closed

Committed. Thanks!