Bug 177615 - security/openssh-askpass requires USE_GCC=any
Summary: security/openssh-askpass requires USE_GCC=any
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-03 16:30 UTC by Sean Bruno
Modified: 2013-05-04 15:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2013-04-03 16:30:01 UTC
Using clang to compile security/openssh-askpass fails:

imake -DUseInstalled -I/usr/local/lib/X11/config
In file included from Imakefile.c:16:
In file included from /usr/local/lib/X11/config/Imake.tmpl:109:
/usr/local/lib/X11/config/FreeBSD.cf:451:35: error: '#' is not followed by a macro parameter
#define IncludeMakefile(file) @@# dependencies are in .depend
                                  ^
In file included from Imakefile.c:16:
In file included from /usr/local/lib/X11/config/Imake.tmpl:316:
/usr/local/lib/X11/config/Imake.rules:1674:27: warning: empty character constant [-Winvalid-pp-token]
        for flag in ${MAKEFLAGS} ''; do \                               @@\
                                 ^
/usr/local/lib/X11/config/Imake.rules:1897:35: error: '#' is not followed by a macro parameter
#define IncludeMakefile(file) @@# dependencies are in .depend
                                  ^
In file included from Imakefile.c:16:
/usr/local/lib/X11/config/Imake.tmpl:2144:10: fatal error: ' X11 .rules' file not found
#include ProjectRulesFile
         ^
/usr/local/lib/X11/config/Imake.tmpl:2142:35: note: expanded from macro 'ProjectRulesFile'
# define ProjectRulesFile       Concat3(<,TopLevelProject,.rules>)
                                        ^
/usr/local/lib/X11/config/Imake.rules:256:23: note: expanded from macro 'Concat3'
#define Concat3(a,b,c)a/**/b/**/c
                      ^
1 warning and 3 errors generated.
imake: Exit code 1.
  Stop.
===>  Building for OpenSSH-askpass-1.2.4.1
"Makefile", line 11: Need an operator
"Makefile", line 12: Need an operator
"Makefile", line 15: Need an operator
"Makefile", line 16: Need an operator
"Makefile", line 17: Need an operator
"Makefile", line 18: Need an operator
"Makefile", line 20: Need an operator
"Makefile", line 38: Need an operator
"Makefile", line 39: Need an operator
"Makefile", line 40: Need an operator
"Makefile", line 56: Need an operator
"Makefile", line 57: Need an operator
"Makefile", line 62: Need an operator
"Makefile", line 63: Need an operator
"Makefile", line 64: Need an operator
"Makefile", line 147: Need an operator
"Makefile", line 148: Need an operator
"Makefile", line 149: Need an operator
"Makefile", line 162: Need an operator
"Makefile", line 163: Need an operator
"Makefile", line 166: Need an operator
"Makefile", line 167: Need an operator
"Makefile", line 168: Need an operator
"Makefile", line 169: Need an operator
"Makefile", line 256: Need an operator
"Makefile", line 475: Need an operator
"Makefile", line 516: Need an operator
"Makefile", line 517: Need an operator
"Makefile", line 521: Need an operator
"Makefile", line 522: Need an operator
"Makefile", line 523: Need an operator
"Makefile", line 524: Need an operator
"Makefile", line 526: Need an operator
"Makefile", line 527: Need an operator
"Makefile", line 528: Need an operator
"Makefile", line 529: Need an operator
"Makefile", line 530: Need an operator
"Makefile", line 531: Need an operator
"Makefile", line 532: Need an operator
"Makefile", line 533: Need an operator
"Makefile", line 534: Need an operator
"Makefile", line 535: Need an operator
"Makefile", line 536: Need an operator
"Makefile", line 537: Need an operator
"Makefile", line 538: Need an operator
"Makefile", line 539: Need an operator
"Makefile", line 544: Need an operator
"Makefile", line 551: Need an operator
"Makefile", line 552: Need an operator
"Makefile", line 553: Need an operator
"Makefile", line 554: Need an operator
"Makefile", line 630: Need an operator
"Makefile", line 632: Need an operator
"Makefile", line 636: Need an operator
"Makefile", line 641: Need an operator
"Makefile", line 644: Need an operator
"Makefile", line 649: Need an operator
"Makefile", line 656: Need an operator
"Makefile", line 661: Need an operator
"Makefile", line 668: Need an operator
"Makefile", line 672: Need an operator
"Makefile", line 676: Need an operator
"Makefile", line 679: Need an operator
"Makefile", line 682: Need an operator
"Makefile", line 685: Need an operator
"Makefile", line 686: Need an operator
"Makefile", line 689: Need an operator
"Makefile", line 692: Need an operator
"Makefile", line 697: Need an operator
"Makefile", line 698: Need an operator
"Makefile", line 699: Need an operator
"Makefile", line 700: Need an operator
"Makefile", line 701: Need an operator
"Makefile", line 702: Need an operator
"Makefile", line 703: Need an operator
"Makefile", line 704: Need an operator
"Makefile", line 707: Need an operator
"Makefile", line 708: Need an operator
"Makefile", line 711: Need an operator
"Makefile", line 716: Need an operator
"Makefile", line 721: Need an operator
"Makefile", line 724: Need an operator
"Makefile", line 757: Need an operator
"Makefile", line 758: Need an operator
"Makefile", line 761: Need an operator
"Makefile", line 764: Need an operator
"Makefile", line 767: Need an operator
"Makefile", line 780: Need an operator
"Makefile", line 783: Need an operator
"Makefile", line 784: Need an operator
"Makefile", line 785: Missing dependency operator
make: fatal errors encountered -- cannot continue
*** [do-build] Error code 1

Stop in /usr/ports/security/openssh-askpass.

Fix: 

set USE_GCC=any in the port makefile
How-To-Repeat: set base compiler to clang and build port
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-03 16:30:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->hrs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Hiroki Sato freebsd_committer freebsd_triage 2013-05-04 15:47:05 UTC
State Changed
From-To: open->closed

Committed as r317323.  Thank you for your report.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-05-04 15:47:09 UTC
Author: hrs
Date: Sat May  4 14:46:56 2013
New Revision: 317323
URL: http://svnweb.freebsd.org/changeset/ports/317323

Log:
  - Add a workaround when CC=clang [*].
  - Trim old-style header.
  - Use OPTIONS_DEFINE.
  
  Pointed out by:	sbruno [*]
  PR:		ports/177615 [*]

Modified:
  head/security/openssh-askpass/Makefile

Modified: head/security/openssh-askpass/Makefile
==============================================================================
--- head/security/openssh-askpass/Makefile	Sat May  4 14:29:12 2013	(r317322)
+++ head/security/openssh-askpass/Makefile	Sat May  4 14:46:56 2013	(r317323)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	OpenSSH-askpass
-# Date created:		27 February 2000
-# Whom:			Kris Kennaway <kris@FreeBSD.org>
-#
+# Created by: Kris Kennaway <kris@FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	OpenSSH-askpass
 PORTVERSION=	1.2.4.1
@@ -15,23 +11,28 @@ MAINTAINER=	hrs@FreeBSD.org
 COMMENT=	Graphical password applet for entering SSH passphrase
 
 USE_IMAKE=	yes
+USE_GCC=	any
 USE_XORG=	x11 xt
 
-MAN1=		x11-ssh-askpass.1
-MLINKS=		x11-ssh-askpass.1 ssh-askpass.1
-
 DOCSDIR=	${PREFIX}/share/doc/ssh-askpass
 PLIST_FILES=	bin/x11-ssh-askpass \
 		bin/ssh-askpass \
 		lib/X11/app-defaults/SshAskpass
 PORTDOCS=	README TODO ChangeLog
 
+MAN1=		x11-ssh-askpass.1
+MLINKS=		x11-ssh-askpass.1 ssh-askpass.1
+
+OPTIONS_DEFINE=	DOCS
+
+.include <bsd.port.options.mk>
+
 pre-configure:
 	cd ${WRKSRC} && ./configure --libexecdir=${PREFIX}/bin
 
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 post-install:
-	${MKDIR} ${DOCSDIR}
+	@${MKDIR} ${DOCSDIR}
 	cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR}
 .endif
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"