Bug 178059 - [patch] 2 fixes for devel/py-dateutil
Summary: [patch] 2 fixes for devel/py-dateutil
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Nicola Vitale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-22 20:30 UTC by Antoine Brodin
Modified: 2013-05-06 18:00 UTC (History)
1 user (show)

See Also:

Attachments
py-dateutil.diff (759 bytes, patch)
2013-04-22 20:30 UTC, Antoine Brodin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Brodin freebsd_committer freebsd_triage 2013-04-22 20:30:00 UTC 
devel/py-dateutil has 2 problems:
1) it installs zoneinfo--latest.tar.gz with wrong permissions
2) it tries to load winreg on python2 instead or _winreg which causes problem if there is already a module called winreg (this is possible on python2, I am porting something that does this)

How-To-Repeat: For 1), run regression tests as non-root after installation -> some tests will fail
For 2), with python2,  touch winreg.py ,  then  python -m dateutil.parser -> this will fail
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-04-22 20:30:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->nivit

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-05-06 17:57:28 UTC 
Author: antoine
Date: Mon May  6 16:57:13 2013
New Revision: 317532
URL: http://svnweb.freebsd.org/changeset/ports/317532

Log:
  Install zoneinfo--latest.tar.gz with good permissions
  Try to import the right module (_winreg not winreg) when using python2
  
  PR:		ports/178059
  Approved by:	maintainer timeout (2 weeks), eadler (mentor)

Modified:
  head/devel/py-dateutil/Makefile

Modified: head/devel/py-dateutil/Makefile
==============================================================================
--- head/devel/py-dateutil/Makefile	Mon May  6 16:29:48 2013	(r317531)
+++ head/devel/py-dateutil/Makefile	Mon May  6 16:57:13 2013	(r317532)
@@ -3,7 +3,7 @@
 
 PORTNAME=	dateutil
 PORTVERSION=	2.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel python
 MASTER_SITES=	CHEESESHOP
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
@@ -23,7 +23,8 @@ PYDISTUTILS_PKGNAME=	python-dateutil
 
 # Fix incorrect permissions
 post-patch:
-	@${FIND} ${WRKSRC}/python_dateutil.egg-info -type f -exec ${CHMOD} ${SHAREMODE} {} ";"
+	@${FIND} ${WRKSRC} -type f -exec ${CHMOD} ${SHAREMODE} {} ";"
+	@${REINPLACE_CMD} -e 's|import winreg|from six.moves import winreg|' ${WRKSRC}/dateutil/tzwin.py
 
 regression-test: build
 	@cd ${WRKSRC} && ${PYTHON_CMD} test.py
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2013-05-06 17:58:32 UTC 
State Changed
From-To: open->closed

Patch committed.