Bug 178303 - [patch] rewrite net-mgmt/tork to use new options framework and comply with bmake
Summary: [patch] rewrite net-mgmt/tork to use new options framework and comply with bmake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-03 00:20 UTC by Emanuel Haupt
Modified: 2013-05-06 16:20 UTC (History)
0 users

See Also:


Attachments
tork.patch (2.70 KB, patch)
2013-05-03 00:20 UTC, Emanuel Haupt
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emanuel Haupt freebsd_committer freebsd_triage 2013-05-03 00:20:00 UTC
- Rewrite net-mgmt/tork to use new options framework
- Fix build with devel/bmake
- WWW disappeared, use freecode page as an alternative
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-03 00:20:07 UTC
Maintainer of net-mgmt/tork,

Please note that PR ports/178303 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178303

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-03 00:20:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2013-05-03 00:27:50 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

I will take care of it.
Comment 4 Emanuel Haupt freebsd_committer freebsd_triage 2013-05-03 00:33:38 UTC
The following patch also removes mail/mixminion as an option which does not
work anymore since it uses an unsupported python version.

--- tork.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 317168)
+++ Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	tork
 PORTVERSION=	0.30
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	net-mgmt security
 MASTER_SITES=	SF/${PORTNAME}/TorK%20Source%20Tarball/TorK-${PORTVERSION}
 
@@ -26,42 +26,28 @@
 MAN5=		torksocks.conf.5
 MAN8=		torksocks.8
 
-HAVE_TOR!=	if pkg_info -I tor-\* >/dev/null 2>&1 ; then ${ECHO} YES; fi
+OPTIONS_DEFINE=		PRIVOXY
 
-.if (${HAVE_TOR} == "YES")
-HAVE_TOR_DEVEL!=	if pkg_info -I tor-devel\* >/dev/null 2>&1 ; then ${ECHO} YES; fi
+PRIVOXY_DESC=		Install privoxy
 
-.if (${HAVE_TOR_DEVEL} == "YES")
-OPTIONS=	TOR_DEVEL	"Depend on tor-devel (already installed)"   On
-.else
-OPTIONS=	TOR	"Depend on tor (already installed)" On
-.endif
+OPTIONS_SINGLE=		TOR
+OPTIONS_SINGLE_TOR=	TOR_STD TOR_DEVEL
 
-.else
-OPTIONS=	TOR_DEVEL	"Depend on tor-devel"   On \
-		TOR	"Depend on tor"     Off
-.endif
+TOR_STD_DESC=		Use stable security/tor port
+TOR_DEVEL_DESC=		Use development security/tor-devel port
 
-OPTIONS+=	PRIVOXY	"Install privoxy"	On \
-		MIXMINION "Install mixminion"	Off
+OPTIONS_DEFAULT=	TOR_STD PRIVOXY
 
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
-.if defined(WITH_TOR_DEVEL)
-.if defined(WITH_TOR)
-IGNORE=			cannot depend on tor and tor-devel at the same time
-.endif
-RUN_DEPENDS+=	${LOCALBASE}/bin/tor:${PORTSDIR}/security/tor-devel
-.elif defined(WITH_TOR)
+.if ${PORT_OPTIONS:MTOR_STD}
 RUN_DEPENDS+=	${LOCALBASE}/bin/tor:${PORTSDIR}/security/tor
+.else
+RUN_DEPENDS+=	${LOCALBASE}/share/tor/geoip6:${PORTSDIR}/security/tor-devel
 .endif
 
-.if defined(WITH_PRIVOXY)
+.if ${PORT_OPTIONS:MPRIVOXY}
 RUN_DEPENDS+=	${LOCALBASE}/sbin/privoxy:${PORTSDIR}/www/privoxy
 .endif
 
-.if defined(WITH_MIXMINION)
-RUN_DEPENDS+=	${LOCALBASE}/bin/mixminion:${PORTSDIR}/mail/mixminion
-.endif
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
Index: pkg-descr
===================================================================
--- pkg-descr	(revision 317168)
+++ pkg-descr	(working copy)
@@ -1,7 +1,7 @@
 TorK is a powerful anonymity manager for the KDE Desktop on Linux and Unix
-systems. It first helps you to install, configure and use Tor. It then
-reduces the task of anonymizing most applications to a single-click, including
-Firefox, Opera, Konqueror, Pidgin, Kopete, SSH, and IRC. For advanced users
-TorK provides detailed network information, and more, in an accessible manner.
+systems. It first helps you to install, configure and use Tor. It then reduces
+the task of anonymizing most applications to a single-click, including Firefox,
+Opera, Konqueror, Pidgin, Kopete, SSH, and IRC. For advanced users TorK provides
+detailed network information, and more, in an accessible manner.
 
-WWW: http://www.anonymityanywhere.com/tork/
+WWW: http://freecode.com/projects/tork
--- tork.patch ends here ---
Comment 5 Emanuel Haupt 2013-05-03 00:55:55 UTC
Patch got mangled, please use:
http://people.freebsd.org/~ehaupt/patches/tork2.patch
Comment 6 Thomas Sander 2013-05-06 15:57:11 UTC
Hello,

i approve the patch.



2013/5/3 Edwin Groothuis <edwin@freebsd.org>

> Maintainer of net-mgmt/tork,
>
> Please note that PR ports/178303 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178303
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Comment 7 Emanuel Haupt freebsd_committer freebsd_triage 2013-05-06 16:10:06 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 8 dfilter service freebsd_committer freebsd_triage 2013-05-06 16:10:06 UTC
Author: ehaupt
Date: Mon May  6 15:09:53 2013
New Revision: 317520
URL: http://svnweb.freebsd.org/changeset/ports/317520

Log:
  - Rewrite to use new options framework
  - Fix build with devel/bmake
  - WWW disappeared, use freecode page as an alternative
  - Remove mail/mixminion as an option since it requires an unsupported python
    version
  
  PR:             178303
  Approved by:    Thomas Sander <thomas.sander@gmx.de> (maintainer)

Modified:
  head/net-mgmt/tork/Makefile
  head/net-mgmt/tork/pkg-descr

Modified: head/net-mgmt/tork/Makefile
==============================================================================
--- head/net-mgmt/tork/Makefile	Mon May  6 14:49:11 2013	(r317519)
+++ head/net-mgmt/tork/Makefile	Mon May  6 15:09:53 2013	(r317520)
@@ -3,7 +3,7 @@
 
 PORTNAME=	tork
 PORTVERSION=	0.30
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	net-mgmt security
 MASTER_SITES=	SF/${PORTNAME}/TorK%20Source%20Tarball/TorK-${PORTVERSION}
 
@@ -26,42 +26,28 @@ MAN1=		tork.1 torkarkollon.1 torkify.1 t
 MAN5=		torksocks.conf.5
 MAN8=		torksocks.8
 
-HAVE_TOR!=	if pkg_info -I tor-\* >/dev/null 2>&1 ; then ${ECHO} YES; fi
+OPTIONS_DEFINE=		PRIVOXY
 
-.if (${HAVE_TOR} == "YES")
-HAVE_TOR_DEVEL!=	if pkg_info -I tor-devel\* >/dev/null 2>&1 ; then ${ECHO} YES; fi
+PRIVOXY_DESC=		Install privoxy
 
-.if (${HAVE_TOR_DEVEL} == "YES")
-OPTIONS=	TOR_DEVEL	"Depend on tor-devel (already installed)"   On
-.else
-OPTIONS=	TOR	"Depend on tor (already installed)" On
-.endif
+OPTIONS_SINGLE=		TOR
+OPTIONS_SINGLE_TOR=	TOR_STD TOR_DEVEL
 
-.else
-OPTIONS=	TOR_DEVEL	"Depend on tor-devel"   On \
-		TOR	"Depend on tor"     Off
-.endif
+TOR_STD_DESC=		Use stable security/tor port
+TOR_DEVEL_DESC=		Use development security/tor-devel port
 
-OPTIONS+=	PRIVOXY	"Install privoxy"	On \
-		MIXMINION "Install mixminion"	Off
+OPTIONS_DEFAULT=	TOR_STD PRIVOXY
 
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
-.if defined(WITH_TOR_DEVEL)
-.if defined(WITH_TOR)
-IGNORE=			cannot depend on tor and tor-devel at the same time
-.endif
-RUN_DEPENDS+=	${LOCALBASE}/bin/tor:${PORTSDIR}/security/tor-devel
-.elif defined(WITH_TOR)
+.if ${PORT_OPTIONS:MTOR_STD}
 RUN_DEPENDS+=	${LOCALBASE}/bin/tor:${PORTSDIR}/security/tor
+.else
+RUN_DEPENDS+=	${LOCALBASE}/share/tor/geoip6:${PORTSDIR}/security/tor-devel
 .endif
 
-.if defined(WITH_PRIVOXY)
+.if ${PORT_OPTIONS:MPRIVOXY}
 RUN_DEPENDS+=	${LOCALBASE}/sbin/privoxy:${PORTSDIR}/www/privoxy
 .endif
 
-.if defined(WITH_MIXMINION)
-RUN_DEPENDS+=	${LOCALBASE}/bin/mixminion:${PORTSDIR}/mail/mixminion
-.endif
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/net-mgmt/tork/pkg-descr
==============================================================================
--- head/net-mgmt/tork/pkg-descr	Mon May  6 14:49:11 2013	(r317519)
+++ head/net-mgmt/tork/pkg-descr	Mon May  6 15:09:53 2013	(r317520)
@@ -1,7 +1,7 @@
 TorK is a powerful anonymity manager for the KDE Desktop on Linux and Unix
-systems. It first helps you to install, configure and use Tor. It then
-reduces the task of anonymizing most applications to a single-click, including
-Firefox, Opera, Konqueror, Pidgin, Kopete, SSH, and IRC. For advanced users
-TorK provides detailed network information, and more, in an accessible manner.
+systems. It first helps you to install, configure and use Tor. It then reduces
+the task of anonymizing most applications to a single-click, including Firefox,
+Opera, Konqueror, Pidgin, Kopete, SSH, and IRC. For advanced users TorK provides
+detailed network information, and more, in an accessible manner.
 
-WWW: http://www.anonymityanywhere.com/tork/
+WWW: http://freecode.com/projects/tork
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"