Allow pgsql in /etc/nssswitch.conf, similar to libnss-mysql. Fix: Patch attached with submission follows:
The port didn't install the link /usr/local/lib/nss_pgsql.so.1 which is essential to make this work. This update fixes that.
Hi, Could you check the list of extra files and directories installed by this port and was not deinstalled by 'make deinstall' ? Check this log: https://redports.org/~lippe/20130628211701-6401-129836/libnss-pgsql-1.5.0.log Tks lippe@
Responsible Changed From-To: freebsd-ports-bugs->lippe I'll take it.
This is a multi-part message in MIME format.
And one more update. An nsswitch.conf applicable to FreeBSD, not the default Linux one.
Hi Berend, Since this is a beta version, it should be used as PORTNAME-devel instead, same that this project was not updates since 2008. Suggestion: Could you create a libnss-pgsql with 1.4.0 stable release and an libnss-pgsql-devel with 1.5.0 beta release, what´s about? Thanks lippe@
>>>>> "Felippe" == Felippe de Meirelles Motta <lippe@FreeBSD.org> writes: Felippe> Since this is a beta version, it should be used as Felippe> PORTNAME-devel instead, same that this project was not Felippe> updates since 2008. Hi Felippe, I could use -devel but it has been pretty stable :-) But I assume -devel is standard. Do I need to submit a new .shar ? Felippe> Suggestion: Could you create a libnss-pgsql with 1.4.0 Felippe> stable release and an libnss-pgsql-devel with 1.5.0 beta Felippe> release, what´s about? I wouldn't have the time to test it thoroughly. I have been using this 1.5.0-beta in production and has been stable so far. So my concern is that we mark it as stable, but no one has actually ever used it. I can't remember, but I think I also had more trouble getting the 1.4.0 version working. But I agree, Debian/Ubuntu all use the 1.4 version. Please let me know what to do. -- All the best, Berend de Boer ------------------------------------------------------ Awesome Drupal hosting: https://www.xplainhosting.com/
Hi Berend, Yes, please! One SHAR file to -devel at this PR and a new PR to stable version. Thanks lippe@ On Fri, Jul 12, 2013 at 7:16 PM, Berend de Boer <berend@pobox.com> wrote: > >>>>> "Felippe" == Felippe de Meirelles Motta <lippe@FreeBSD.org> writes: > > Felippe> Since this is a beta version, it should be used as > Felippe> PORTNAME-devel instead, same that this project was not > Felippe> updates since 2008. > > Hi Felippe, > > I could use -devel but it has been pretty stable :-) But I assume > -devel is standard. > > Do I need to submit a new .shar ? > > > Felippe> Suggestion: Could you create a libnss-pgsql with 1.4.0 > Felippe> stable release and an libnss-pgsql-devel with 1.5.0 beta > Felippe> release, what´s about? > > I wouldn't have the time to test it thoroughly. I have been using this > 1.5.0-beta in production and has been stable so far. So my concern is > that we mark it as stable, but no one has actually ever used it. > > I can't remember, but I think I also had more trouble getting the > 1.4.0 version working. > > But I agree, Debian/Ubuntu all use the 1.4 version. > > Please let me know what to do. > > -- > All the best, > > Berend de Boer > > > ------------------------------------------------------ > Awesome Drupal hosting: https://www.xplainhosting.com/ > >
>>>>> "Felippe" == Felippe de Meirelles Motta <lippe@FreeBSD.org> writes: Felippe> Yes, please! One SHAR file to -devel at this PR and a new Felippe> PR to stable version. Hi Felippe, Took me a while, this is the -devel shar.
Given that the port proposed does not comply to current ports standards and frameworks and the original submitter remained silent since the original submission, I am rejecting this PR and closing it.
Created attachment 155927 [details] Port now complies with latest port standards
Have updated the port, now works against latest ports standards.
Created attachment 159942 [details] Update shar with xmlto dependency The build depends on xmlto. I added it as a BUILD_DEPENDS
lippe@'s commit bit has been taken for safekeeping. To submitter: I'm sorry that this PR has sat for so long.
There are still few issues with the proposed shar: - portlint is throwing makepatch warnings, please, eliminate them all - shar contains 'files/nsswitch.conf~' that I think shouldnt be there - BUILD_DEPENDS should appear earlier - shar results in port dir called libnss-pgsql-devel, yet in Makefile the PORTNAME is libnss-pgsql, this should be corrected - are you sure this line is correct: '${LN} -s ${PREFIX}/lib/libnss_pgsql.so.2.0.0 ${STAGEDIR}${PREFIX}/lib/nss_pgsql.so.1' (shouldnt this be handled automatically?)
Created attachment 164447 [details] Updated port submission I have updated the shar archive, fixing the following: - fixed makepatch warnings - removed unnecessary files - update Makefile variables - fixed port directory name - removed unnecessary post-install steps
Thank you Felix
Is there anything more required for this new port? It would be nice to see some movement.
Distsite is not available: make fetch ===> libnss-pgsql-1.5.0_1 depends on file: /usr/local/sbin/pkg - found => libnss-pgsql-1.5.0-beta.tar.gz doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch http://pgfoundry.org/frs/download.php/1878/libnss-pgsql-1.5.0-beta.tar.gz fetch: http://pgfoundry.org/frs/download.php/1878/libnss-pgsql-1.5.0-beta.tar.gz: Operation timed out
Created attachment 169140 [details] Updated port submission Not sure what has happened to pgfoundry but this new shar references a postgres repository.
Thanks. After a bit of tweaking, it fetches and builds. There's a strange effect. If I build it in poudriere, it fails with a plist issue: ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: lib/libnss_pgsql.so.2 If I build in the ports tree, the .so.2 is not installed and the plist is correct. This is really strange.
If I add USES=autoreconf, it builds fine in both cases. Yay!
A commit references this bug: Author: pi Date: Sun Apr 10 12:27:49 UTC 2016 New revision: 412926 URL: https://svnweb.freebsd.org/changeset/ports/412926 Log: New port: net/libnss-pgsql libNSS-PostgreSQL allows you to authenticate UNIX groups and users using a PostgreSQL database. It uses the NSS API which provides an abstraction layer between the UNIX authentication API and the related data. NSS-PostgreSQL currently supports the passwd and groups services. WWW: https://ftp.postgresql.org/pub/projects/pgFoundry/sysauth/NSS/ PR: 178333 Submitted by: berend@pobox.com, felix@userspace.com.au Reviewed by: lippe, robak Changes: head/net/Makefile head/net/libnss-pgsql/ head/net/libnss-pgsql/Makefile head/net/libnss-pgsql/distinfo head/net/libnss-pgsql/files/ head/net/libnss-pgsql/files/nsswitch.conf head/net/libnss-pgsql/files/patch-configure.ac head/net/libnss-pgsql/files/patch-src_backend.c head/net/libnss-pgsql/files/patch-src_interface.c head/net/libnss-pgsql/files/patch-src_nss-pgsql.h head/net/libnss-pgsql/pkg-descr head/net/libnss-pgsql/pkg-plist
This finally hit the tree, close to its third birthday 8-} Thanks to all of you for the work, reviews, updates, etc, and sorry, that it took so long!