Bug 179275 - multimedia/banshee: remove (disabled) boo support
multimedia/banshee: remove (disabled) boo support
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: mono
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-03 22:50 UTC by Rene Ladan
Modified: 2013-06-19 12:40 UTC (History)
0 users

See Also:


Attachments
file.diff (2.38 KB, patch)
2013-06-03 22:50 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer 2013-06-03 22:50:00 UTC
There is a disabled option for Boo support in multimedia/banshee, but lang/boo is broken and expired. Fully remove Boo support to allow lang/boo to be removed.

While here pet portlint and fix the MPT option.

Fix: Patch attached with submission follows:
How-To-Repeat: `Tools/scripts/rmport lang/boo` finds this port as a dependent one.
Comment 1 Edwin Groothuis freebsd_committer 2013-06-03 22:50:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mono

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2013-06-19 12:32:34 UTC
Author: rene
Date: Wed Jun 19 11:32:27 2013
New Revision: 321239
URL: http://svnweb.freebsd.org/changeset/ports/321239

Log:
  - Remove the BOO option, this depends on the expired port lang/boo
  - Fix MTP option
  - Pet portlint
  
  PR:		ports/179275
  Submitted by:	myself
  Approved by:	maintainer timeout (mono@, 16 days)

Modified:
  head/multimedia/banshee/Makefile
  head/multimedia/banshee/pkg-plist   (contents, props changed)

Modified: head/multimedia/banshee/Makefile
==============================================================================
--- head/multimedia/banshee/Makefile	Wed Jun 19 11:15:28 2013	(r321238)
+++ head/multimedia/banshee/Makefile	Wed Jun 19 11:32:27 2013	(r321239)
@@ -22,14 +22,13 @@ LIB_PC_DEPENDS=	${LOCALBASE}/libdata/pkg
 		${LOCALBASE}/libdata/pkgconfig/mono-addins.pc:${PORTSDIR}/devel/mono-addins \
 		${LOCALBASE}/libdata/pkgconfig/notify-sharp.pc:${PORTSDIR}/devel/notify-sharp
 
-# For now, remove APPLEDEV and BOO since they are broken
+# For now, remove APPLEDEV since it is broken
 OPTIONS_DEFINE=	DOCS BPMDETECT GIO MTP WEBKIT YOUTUBE
 
 APPLEDEV_DESC=	Apple device
-BOO_DESC=	Boo
 BPMDETECT_DESC=	Force dependency on soundtouch (required for BPM detection)
 GIO_DESC=	Use GIO for disk access
-WEBKIT_DESC=	Build and/or install extensions using Webkit 
+WEBKIT_DESC=	Build and/or install extensions using Webkit
 YOUTUBE_DESC=	Build and/or install the Youtube extension
 
 OPTIONS_DEFAULT=BPMDETECT GIO MTP WEBKIT YOUTUBE
@@ -45,7 +44,7 @@ USE_XORG=	xrandr xxf86vm
 USE_SQLITE=	yes
 INSTALLS_ICONS=	yes
 CONFIGURE_TARGET=	--build=${ARCH}-portbld-freebsd${OSREL}
-CONFIGURE_ARGS=	--with-vendor-build-id=FreeBSD\ BSD\#\ Project --disable-gio-hardware
+CONFIGURE_ARGS=	--with-vendor-build-id=FreeBSD\ BSD\#\ Project --disable-gio-hardware --disable-boo
 
 .include <bsd.port.options.mk>
 
@@ -83,16 +82,6 @@ PLIST_SUB+=	OPT_DOCS="@comment "
 USE_GSTREAMER+=	soundtouch
 .endif
 
-.if ${PORT_OPTIONS:MBOO}
-CONFIGURE_ARGS+=--enable-boo
-BUILD_DEPENDS+=	booc:${PORTSDIR}/lang/boo
-RUN_DEPENDS+=	booc:${PORTSDIR}/lang/boo
-PLIST_SUB+=	OPT_BOO=""
-.else
-CONFIGURE_ARGS+=--disable-boo
-PLIST_SUB+=	OPT_BOO="@comment "
-.endif
-
 .if ${PORT_OPTIONS:MAPPLEDEV}
 CONFIGURE_ARGS+=--enable-appledevice
 LIB_PC_DEPENDS+=${LOCALBASE}/libdata/pkgconfig/libgpodsharp.pc:${PORTSDIR}/audio/libgpod
@@ -103,7 +92,7 @@ CONFIGURE_ARGS+=--disable-appledevice
 PLIST_SUB+=	APPLEDEV="@comment "
 .endif
 
-.if ${PORTSDIR:MMTP}
+.if ${PORT_OPTIONS:MMTP}
 CONFIGURE_ARGS+=--enable-mtp
 LIB_DEPENDS+=	mtp:${PORTSDIR}/audio/libmtp
 PLIST_SUB+=	OPT_MTP=""

Modified: head/multimedia/banshee/pkg-plist
==============================================================================
--- head/multimedia/banshee/pkg-plist	Wed Jun 19 11:15:28 2013	(r321238)
+++ head/multimedia/banshee/pkg-plist	Wed Jun 19 11:32:27 2013	(r321239)
@@ -49,8 +49,6 @@ lib/banshee/Extensions/Banshee.AmazonMp3
 lib/banshee/Extensions/Banshee.AmazonMp3.exe.mdb
 lib/banshee/Extensions/Banshee.Audiobook.dll
 lib/banshee/Extensions/Banshee.Audiobook.dll.mdb
-%%OPT_BOO%%lib/banshee/Extensions/Banshee.BooScript.dll
-%%OPT_BOO%%lib/banshee/Extensions/Banshee.BooScript.dll.mdb
 lib/banshee/Extensions/Banshee.Bpm.dll
 lib/banshee/Extensions/Banshee.Bpm.dll.mdb
 lib/banshee/Extensions/Banshee.CoverArt.dll
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Rene Ladan freebsd_committer 2013-06-19 12:33:01 UTC
State Changed
From-To: open->closed

Committed, maintainer timeout